Re: insight/243: broken itcl man pages

Re: insight/243: broken itcl man pages

[kseitz]

Synopsis: broken itcl man pages

Responsible-Changed-From-To: unassigned->kseitz
Responsible-Changed-By: kseitz
Responsible-Changed-When: Thu Sep  1 05:32:54 2005
Responsible-Changed-Why:
    mine
State-Changed-From-To: open->closed
State-Changed-By: kseitz
State-Changed-When: Thu Sep  1 05:32:54 2005
State-Changed-Why:
    I've committed your patches. Thank you for pointing that out.

http://sourceware.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=insight&pr=243

insight/243: broken itcl man pages

[Jay.St.Pierre]

>Number:         243
>Category:       insight
>Synopsis:       broken itcl man pages
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 02 19:53:01 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Jay.St.Pierre@Colorado.EDU
>Release:        insight-6.0
>Organization:
>Environment:
Solaris 2.8
>Description:
The itcl/itk man pages are installed with a ".so man.macros" line that cause the man pages to be unparseable.  The raw tcl/tk man pages have the same line, but when the get installed this line is replaced with the contents of man.macros.  So I just modified the itcl/itk Makefile.in files to include the same installation logic as tcl/tk uses.

The patch I used is attached to this bug report.
>How-To-Repeat:
After you install insight-6.0, attempt to use man or nroff to view an itcl/itk manpage installed in the mann directory.  For example, itcl.
>Fix:
diff -ur insight-6.0 insight-6.0.fixed
--- insight-6.0/itcl/itcl/Makefile.in   2003-01-21 13:40:25.000000000 -0700
+++ insight-6.0.fixed/itcl/itcl/Makefile.in     2003-10-31 13:21:56.626003000 -0700
@@ -292,10 +292,12 @@
 install-doc: doc
        $(mkinstalldirs) $(mandir)/mann
        @echo "Installing man pages in $(mandir)"
-       @for i in $(srcdir)/doc/*.n; \
+       @cd $(srcdir)/doc; for i in *.n; \
            do \
            echo "Installing $$i"; \
-           $(INSTALL_DATA) $$i $(mandir)/mann ; \
+           sed -e '/man\.macros/r man.macros' -e '/man\.macros/d' \
+           $$i > $(mandir)/mann/$$i; \
+           chmod 444 $(mandir)/mann/$$i; \
            done
  
 test: $(TCLSH_PROG)
--- insight-6.0/itcl/itk/Makefile.in    2003-01-21 13:40:29.000000000 -0700
+++ insight-6.0.fixed/itcl/itk/Makefile.in      2003-11-01 14:01:07.273006000 -0700
@@ -287,10 +287,12 @@
 install-doc: doc
        $(mkinstalldirs) $(mandir)/mann
        @echo "Installing man pages in $(mandir)"
-       @for i in $(srcdir)/doc/*.n; \
+       @cd $(srcdir)/doc; for i in *.n; \
            do \
-           echo "Installing $$i info $(mandir)/mann"; \
-           $(INSTALL_DATA) $$i $(mandir)/mann ; \
+           echo "Installing $$i in $(mandir)/mann"; \
+           sed -e '/man\.macros/r man.macros' -e '/man\.macros/d' \
+           $$i > $(mandir)/mann/$$i; \
+           chmod 444 $(mandir)/mann/$$i; \
            done
  
 test: $(TCLSH_PROG)
>Release-Note:
>Audit-Trail:
>Unformatted: