insight/318: Insight hangs when opening "Target Settings" window

[bernard.haible@gmx.de]

>Number:         318
>Category:       insight
>Synopsis:       Insight hangs when opening "Target Settings" window
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jul 28 14:53:01 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator:     Bernard Haible
>Release:        6.6
>Organization:
>Environment:
Windows XP Prof. / Cygwin / ASUS P5B-E
>Description:
Insight hangs when opening the "Target Settings" window.
>How-To-Repeat:

>Fix:
It seems that the problem is located the function itcl::body TargetSelection::port_list in file targetselection.itb. My PC has only one COM port. When searching for COM port 2 to 4, Insight hangs. 

I changed the search loop as follows, allowing quitting the loop after 1 port instead of 4 in the original code. With that change, it runs fine.

  for {set i 1} {!$quit} {incr i} {
    if {[catch { set fd [::open COM$i: RDWR] } msg]} {
      # Failed.  Find out why.
      if {[string first "permission denied" $msg] != -1} {
	# Port is there, but busy right now. That's OK.
	lappend plist /dev/com$i
      } elseif {$i > 1} {
	# if we've scanned the first 1 ports, then quit when we find no more 
	set quit 1
      }
    } else {
      # We got it.  Now close it and add to list.
      close $fd
      lappend plist /dev/com$i
    }
>Release-Note:
>Audit-Trail:
>Unformatted: