From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27043 invoked by alias); 5 Nov 2008 23:13:01 -0000 Received: (qmail 26985 invoked by uid 71); 5 Nov 2008 23:13:01 -0000 Resent-Date: 5 Nov 2008 23:13:01 -0000 Resent-Message-ID: <20081105231301.26984.qmail@sourceware.org> Resent-From: insight-gnats@sources.redhat.com (GNATS Filer) Resent-To: nobody@sources.redhat.com Resent-Cc: insight-prs@sources.redhat.com Resent-Reply-To: insight-gnats@sources.redhat.com, dktrkranz@ubuntu.com Received: (qmail 24262 invoked by uid 48); 5 Nov 2008 23:04:18 -0000 Message-Id: <20081105230418.24261.qmail@sourceware.org> Date: Wed, 05 Nov 2008 23:13:00 -0000 From: dktrkranz@ubuntu.com Reply-To: dktrkranz@ubuntu.com To: insight-gnats@sources.redhat.com X-Send-Pr-Version: gnatsweb-2.9.3 (1.1.1.1.2.31) Subject: insight/332: Please check some function return codes Mailing-List: contact insight-prs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-prs-owner@sourceware.org X-SW-Source: 2008-q4/txt/msg00000.txt.bz2 >Number: 332 >Category: insight >Synopsis: Please check some function return codes >Confidential: no >Severity: non-critical >Priority: low >Responsible: unassigned >State: open >Class: sw-bug >Submitter-Id: net >Arrival-Date: Wed Nov 05 23:13:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: dktrkranz@ubuntu.com >Release: 6.7.1 >Organization: >Environment: >Description: Some function do not check return codes, this causes insight to fail to build from source in Ubuntu. Attached patch should fix this, you can test it passing -D_FORTIFY_SOURCE=2 to gcc. >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted: ----gnatsweb-attachment---- Content-Type: application/octet-stream; name="05_ubuntu_toolchain_FTBFS.dpatch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="05_ubuntu_toolchain_FTBFS.dpatch" IyEgL2Jpbi9zaCAvdXNyL3NoYXJlL2RwYXRjaC9kcGF0Y2gtcnVuCiMjIDA1X3VidW50dV90b29s Y2hhaW5fRlRCRlMuZHBhdGNoIGJ5ICA8ZGt0cmtyYW56QHVidW50dS5jb20+CiMjIERQOiBGaXgg RlRCRlMgd2l0aCBVYnVudHUgdG9vbGNoYWluLgojIyBEUDogCgpARFBBVENIQApkaWZmIC11ck5h ZCBpbnNpZ2h0LTYuNy4xLmRmc2cuMX4vZ2RiL2NsaS9jbGktY21kcy5jIGluc2lnaHQtNi43LjEu ZGZzZy4xL2dkYi9jbGkvY2xpLWNtZHMuYwotLS0gaW5zaWdodC02LjcuMS5kZnNnLjF+L2dkYi9j bGkvY2xpLWNtZHMuYwkyMDA3LTA4LTIzIDIwOjA4OjQ3LjAwMDAwMDAwMCArMDIwMAorKysgaW5z aWdodC02LjcuMS5kZnNnLjEvZ2RiL2NsaS9jbGktY21kcy5jCTIwMDgtMDgtMDQgMDM6Mzc6NDQu MDAwMDAwMDAwICswMjAwCkBAIC0zMjAsNyArMzIwLDggQEAKIHsKICAgaWYgKGFyZ3MpCiAgICAg ZXJyb3IgKF8oIlRoZSBcInB3ZFwiIGNvbW1hbmQgZG9lcyBub3QgdGFrZSBhbiBhcmd1bWVudDog JXMiKSwgYXJncyk7Ci0gIGdldGN3ZCAoZ2RiX2RpcmJ1Ziwgc2l6ZW9mIChnZGJfZGlyYnVmKSk7 CisgIGlmICghZ2V0Y3dkIChnZGJfZGlyYnVmLCBzaXplb2YgKGdkYl9kaXJidWYpKSkKKyAgICBl cnJvciAoXygiVW5hYmxlIHRvIGRldGVybWluZSBjdXJyZW50IGRpcmVjdG9yeSIpKTsKIAogICBp ZiAoc3RyY21wIChnZGJfZGlyYnVmLCBjdXJyZW50X2RpcmVjdG9yeSkgIT0gMCkKICAgICBwcmlu dGZfdW5maWx0ZXJlZCAoXygiV29ya2luZyBkaXJlY3RvcnkgJXNcbiAoY2Fub25pY2FsbHkgJXMp LlxuIiksCmRpZmYgLXVyTmFkIGluc2lnaHQtNi43LjEuZGZzZy4xfi9nZGIvaW5mbG93LmMgaW5z aWdodC02LjcuMS5kZnNnLjEvZ2RiL2luZmxvdy5jCi0tLSBpbnNpZ2h0LTYuNy4xLmRmc2cuMX4v Z2RiL2luZmxvdy5jCTIwMDctMDgtMjMgMjA6MDg6MzUuMDAwMDAwMDAwICswMjAwCisrKyBpbnNp Z2h0LTYuNy4xLmRmc2cuMS9nZGIvaW5mbG93LmMJMjAwOC0wOC0wNCAwMzozNzo0NC4wMDAwMDAw MDAgKzAyMDAKQEAgLTUxNCw3ICs1MTQsNyBAQAogdm9pZAogbmV3X3R0eSAodm9pZCkKIHsKLSAg aW50IHR0eTsKKyAgaW50IHR0eSwgcnY7CiAKICAgaWYgKGluZmVyaW9yX3RoaXNydW5fdGVybWlu YWwgPT0gMCkKICAgICByZXR1cm47CkBAIC01NDcsMTcgKzU0NywxNyBAQAogICBpZiAodHR5ICE9 IDApCiAgICAgewogICAgICAgY2xvc2UgKDApOwotICAgICAgZHVwICh0dHkpOworICAgICAgcnYg PSBkdXAgKHR0eSk7CiAgICAgfQogICBpZiAodHR5ICE9IDEpCiAgICAgewogICAgICAgY2xvc2Ug KDEpOwotICAgICAgZHVwICh0dHkpOworICAgICAgcnYgPSBkdXAgKHR0eSk7CiAgICAgfQogICBp ZiAodHR5ICE9IDIpCiAgICAgewogICAgICAgY2xvc2UgKDIpOwotICAgICAgZHVwICh0dHkpOwor ICAgICAgcnYgPSBkdXAgKHR0eSk7CiAgICAgfQogICBpZiAodHR5ID4gMikKICAgICBjbG9zZSAo dHR5KTsKZGlmZiAtdXJOYWQgaW5zaWdodC02LjcuMS5kZnNnLjF+L2dkYi9saW51eC1uYXQuYyBp bnNpZ2h0LTYuNy4xLmRmc2cuMS9nZGIvbGludXgtbmF0LmMKLS0tIGluc2lnaHQtNi43LjEuZGZz Zy4xfi9nZGIvbGludXgtbmF0LmMJMjAwNy0wOS0wMiAxNjowNDozMS4wMDAwMDAwMDAgKzAyMDAK KysrIGluc2lnaHQtNi43LjEuZGZzZy4xL2dkYi9saW51eC1uYXQuYwkyMDA4LTA4LTA0IDAzOjM3 OjQ0LjAwMDAwMDAwMCArMDIwMApAQCAtMjgzMSw3ICsyODMxLDggQEAKICAgICAgIHNwcmludGYg KGZuYW1lMSwgIi9wcm9jLyVsbGQvY21kbGluZSIsIHBpZCk7CiAgICAgICBpZiAoKHByb2NmaWxl ID0gZm9wZW4gKGZuYW1lMSwgInIiKSkgIT0gTlVMTCkKIAl7Ci0JICBmZ2V0cyAoYnVmZmVyLCBz aXplb2YgKGJ1ZmZlciksIHByb2NmaWxlKTsKKwkgIGlmICghZmdldHMgKGJ1ZmZlciwgc2l6ZW9m IChidWZmZXIpLCBwcm9jZmlsZSkpCisJICAgIGVycm9yKF8oIlVuYWJsZSB0byByZWFkICclcyci KSwgZm5hbWUxKTsKIAkgIHByaW50Zl9maWx0ZXJlZCAoImNtZGxpbmUgPSAnJXMnXG4iLCBidWZm ZXIpOwogCSAgZmNsb3NlIChwcm9jZmlsZSk7CiAJfQpkaWZmIC11ck5hZCBpbnNpZ2h0LTYuNy4x LmRmc2cuMX4vZ2RiL21haW4uYyBpbnNpZ2h0LTYuNy4xLmRmc2cuMS9nZGIvbWFpbi5jCi0tLSBp bnNpZ2h0LTYuNy4xLmRmc2cuMX4vZ2RiL21haW4uYwkyMDA3LTA4LTIzIDIwOjA4OjM2LjAwMDAw MDAwMCArMDIwMAorKysgaW5zaWdodC02LjcuMS5kZnNnLjEvZ2RiL21haW4uYwkyMDA4LTA4LTA0 IDAzOjM3OjQ0LjAwMDAwMDAwMCArMDIwMApAQCAtMTkzLDcgKzE5Myw4IEBACiAgIGxpbmVbMF0g PSAnXDAnOwkJLyogVGVybWluYXRlIHNhdmVkIChub3cgZW1wdHkpIGNtZCBsaW5lICovCiAgIGlu c3RyZWFtID0gc3RkaW47CiAKLSAgZ2V0Y3dkIChnZGJfZGlyYnVmLCBzaXplb2YgKGdkYl9kaXJi dWYpKTsKKyAgaWYgKCFnZXRjd2QgKGdkYl9kaXJidWYsIHNpemVvZiAoZ2RiX2RpcmJ1ZikpKQor ICAgIGVycm9yIChfKCJVbmFibGUgdG8gZGV0ZXJtaW5lIGN1cnJlbnQgZGlyZWN0b3J5IikpOwog ICBjdXJyZW50X2RpcmVjdG9yeSA9IGdkYl9kaXJidWY7CiAKICAgZ2RiX3N0ZG91dCA9IHN0ZGlv X2ZpbGVvcGVuIChzdGRvdXQpOwpkaWZmIC11ck5hZCBpbnNpZ2h0LTYuNy4xLmRmc2cuMX4vZ2Ri L21pL21pLWNtZC1lbnYuYyBpbnNpZ2h0LTYuNy4xLmRmc2cuMS9nZGIvbWkvbWktY21kLWVudi5j Ci0tLSBpbnNpZ2h0LTYuNy4xLmRmc2cuMX4vZ2RiL21pL21pLWNtZC1lbnYuYwkyMDA3LTA4LTIz IDIwOjA4OjQ4LjAwMDAwMDAwMCArMDIwMAorKysgaW5zaWdodC02LjcuMS5kZnNnLjEvZ2RiL21p L21pLWNtZC1lbnYuYwkyMDA4LTA4LTA0IDAzOjM3OjQ0LjAwMDAwMDAwMCArMDIwMApAQCAtNzgs NyArNzgsOCBAQAogICAgICAKICAgLyogT3RoZXJ3aXNlIHRoZSBtaSBsZXZlbCBpcyAyIG9yIGhp Z2hlci4gICovCiAKLSAgZ2V0Y3dkIChnZGJfZGlyYnVmLCBzaXplb2YgKGdkYl9kaXJidWYpKTsK KyAgaWYgKCFnZXRjd2QgKGdkYl9kaXJidWYsIHNpemVvZiAoZ2RiX2RpcmJ1ZikpKQorICAgIGVy cm9yIChfKCJVbmFibGUgdG8gZGV0ZXJtaW5lIGN1cnJlbnQgZGlyZWN0b3J5IikpOwogICB1aV9v dXRfZmllbGRfc3RyaW5nICh1aW91dCwgImN3ZCIsIGdkYl9kaXJidWYpOwogCiAgIHJldHVybiBN SV9DTURfRE9ORTsKZGlmZiAtdXJOYWQgaW5zaWdodC02LjcuMS5kZnNnLjF+L2dkYi90b3AuYyBp bnNpZ2h0LTYuNy4xLmRmc2cuMS9nZGIvdG9wLmMKLS0tIGluc2lnaHQtNi43LjEuZGZzZy4xfi9n ZGIvdG9wLmMJMjAwNy0wOS0wMiAyMzoxMzo1Ni4wMDAwMDAwMDAgKzAyMDAKKysrIGluc2lnaHQt Ni43LjEuZGZzZy4xL2dkYi90b3AuYwkyMDA4LTA4LTA0IDAzOjM3OjQ0LjAwMDAwMDAwMCArMDIw MApAQCAtMTYyOCw3ICsxNjI4LDggQEAKIAogICAvKiBSdW4gdGhlIGluaXQgZnVuY3Rpb24gb2Yg ZWFjaCBzb3VyY2UgZmlsZSAqLwogCi0gIGdldGN3ZCAoZ2RiX2RpcmJ1Ziwgc2l6ZW9mIChnZGJf ZGlyYnVmKSk7CisgIGlmICghZ2V0Y3dkIChnZGJfZGlyYnVmLCBzaXplb2YgKGdkYl9kaXJidWYp KSkKKyAgICBlcnJvciAoXygiVW5hYmxlIHRvIGRldGVybWluZSBjdXJyZW50IGRpcmVjdG9yeSIp KTsKICAgY3VycmVudF9kaXJlY3RvcnkgPSBnZGJfZGlyYnVmOwogCiAjaWZkZWYgX19NU0RPU19f CmRpZmYgLXVyTmFkIGluc2lnaHQtNi43LjEuZGZzZy4xfi9nZGIvdWktZmlsZS5jIGluc2lnaHQt Ni43LjEuZGZzZy4xL2dkYi91aS1maWxlLmMKLS0tIGluc2lnaHQtNi43LjEuZGZzZy4xfi9nZGIv dWktZmlsZS5jCTIwMDctMDgtMjMgMjA6MDg6NDYuMDAwMDAwMDAwICswMjAwCisrKyBpbnNpZ2h0 LTYuNy4xLmRmc2cuMS9nZGIvdWktZmlsZS5jCTIwMDgtMDgtMDQgMDM6Mzc6NDQuMDAwMDAwMDAw ICswMjAwCkBAIC00NzYsMTEgKzQ3NiwxMiBAQAogc3RhdGljIHZvaWQKIHN0ZGlvX2ZpbGVfd3Jp dGUgKHN0cnVjdCB1aV9maWxlICpmaWxlLCBjb25zdCBjaGFyICpidWYsIGxvbmcgbGVuZ3RoX2J1 ZikKIHsKKyAgaW50IHJ2OwogICBzdHJ1Y3Qgc3RkaW9fZmlsZSAqc3RkaW8gPSB1aV9maWxlX2Rh dGEgKGZpbGUpOwogICBpZiAoc3RkaW8tPm1hZ2ljICE9ICZzdGRpb19maWxlX21hZ2ljKQogICAg IGludGVybmFsX2Vycm9yIChfX0ZJTEVfXywgX19MSU5FX18sCiAJCSAgICBfKCJzdGRpb19maWxl X3dyaXRlOiBiYWQgbWFnaWMgbnVtYmVyIikpOwotICBmd3JpdGUgKGJ1ZiwgbGVuZ3RoX2J1Ziwg MSwgc3RkaW8tPmZpbGUpOworICBydiA9IGZ3cml0ZSAoYnVmLCBsZW5ndGhfYnVmLCAxLCBzdGRp by0+ZmlsZSk7CiB9CiAKIHN0YXRpYyB2b2lkCmRpZmYgLXVyTmFkIGluc2lnaHQtNi43LjEuZGZz Zy4xfi9nZGIvdXRpbHMuYyBpbnNpZ2h0LTYuNy4xLmRmc2cuMS9nZGIvdXRpbHMuYwotLS0gaW5z aWdodC02LjcuMS5kZnNnLjF+L2dkYi91dGlscy5jCTIwMDctMDgtMjMgMjA6MDg6NDYuMDAwMDAw MDAwICswMjAwCisrKyBpbnNpZ2h0LTYuNy4xLmRmc2cuMS9nZGIvdXRpbHMuYwkyMDA4LTA4LTA0 IDAzOjM3OjQ0LjAwMDAwMDAwMCArMDIwMApAQCAtNzAwLDYgKzcwMCw3IEBACiAgIHN0YXRpYyBp bnQgZGVqYXZ1OwogICBpbnQgcXVpdF9wOwogICBpbnQgZHVtcF9jb3JlX3A7CisgIGludCBydjsK ICAgY2hhciAqcmVhc29uOwogCiAgIC8qIERvbid0IGFsbG93IGluZmluaXRlIGVycm9yL3dhcm5p bmcgcmVjdXJzaW9uLiAgKi8KQEAgLTcxNiw3ICs3MTcsNyBAQAogCWFib3J0ICgpOwkvKiBOT1RF OiBHREIgaGFzIG9ubHkgdGhyZWUgY2FsbHMgdG8gYWJvcnQoKS4gICovCiAgICAgICBkZWZhdWx0 OgogCWRlamF2dSA9IDM7Ci0Jd3JpdGUgKFNUREVSUl9GSUxFTk8sIG1zZywgc2l6ZW9mIChtc2cp KTsKKwlydiA9IHdyaXRlIChTVERFUlJfRklMRU5PLCBtc2csIHNpemVvZiAobXNnKSk7CiAJZXhp dCAoMSk7CiAgICAgICB9CiAgIH0K