RE: [RFC] Insight build problem: was [06/15] Per-breakpoint architecture support

["Pierre Muller" <muller@ics.u-strasbg.fr>]

> It's not particularly nice, but I'm OK with leaving it the way
> it was for now ...   Longer term we should find out why the
> exported interfaces like set_breakpoint are not suitable for gdbtk,
> and extend them if necessary.

  Keith, could you answer that question?
I did not investigate that deeply, but 
the parameters of set_raw_breakpoint and set_breakpoint are quite
different...
 
> > @@ -4396,8 +4397,9 @@ static void free_bp_location (struct bp_
> >
> >  /* Helper to set_raw_breakpoint below.  Creates a breakpoint
> >     that has type BPTYPE and has no locations as yet.  */
> > +/* This function is used in gdbtk sources and thus can not be made
> static.
> > */
> >
> > -static struct breakpoint *
> > +struct breakpoint *
> >  set_raw_breakpoint_without_location (struct gdbarch *gdbarch,
> >  				     enum bptype bptype)
> >  {

  Whoops... Sorry about that :(

> This chunk seems unnecessary; set_raw_breakpoint_without_location
> was static before my patch as well.
> 
> The rest is OK.
Thanks,

I committed the following:

2009-07-07  Pierre Muller  <muller@ics.u-strasbg.fr>

	* breakpoint.c (set_raw_breakpoint): Remove static modifier.

Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.412
diff -u -p -r1.412 breakpoint.c
--- breakpoint.c	2 Jul 2009 17:21:05 -0000	1.412
+++ breakpoint.c	7 Jul 2009 22:16:58 -0000
@@ -105,7 +105,8 @@ static void break_command_1 (char *, int
 
 static void mention (struct breakpoint *);
 
-static struct breakpoint *set_raw_breakpoint (struct gdbarch *gdbarch,
+/* This function is used in gdbtk sources and thus can not be made static.
*/
+struct breakpoint *set_raw_breakpoint (struct gdbarch *gdbarch,
 					      struct symtab_and_line,
 					      enum bptype);
 
@@ -4396,6 +4397,7 @@ static void free_bp_location (struct bp_
 
 /* Helper to set_raw_breakpoint below.  Creates a breakpoint
    that has type BPTYPE and has no locations as yet.  */
+/* This function is used in gdbtk sources and thus can not be made static.
*/
 
 static struct breakpoint *
 set_raw_breakpoint_without_location (struct gdbarch *gdbarch,
@@ -4480,7 +4482,7 @@ get_sal_arch (struct symtab_and_line sal
    prior to completing the initialization of the breakpoint.  If this
    should happen, a bogus breakpoint will be left on the chain.  */
 
-static struct breakpoint *
+struct breakpoint *
 set_raw_breakpoint (struct gdbarch *gdbarch,
 		    struct symtab_and_line sal, enum bptype bptype)
 {