From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32004 invoked by alias); 17 Sep 2009 07:04:20 -0000 Received: (qmail 31922 invoked by uid 22791); 17 Sep 2009 07:04:18 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Sep 2009 07:04:11 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n8H73riT051865 ; Thu, 17 Sep 2009 09:03:53 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n8H73r1F087391 ; Thu, 17 Sep 2009 09:03:53 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n8H73qrW090144 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Thu, 17 Sep 2009 09:03:52 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Tom Tromey'" Cc: References: <000001ca36b3$08f0b8c0$1ad22a40$@u-strasbg.fr> In-Reply-To: Subject: RE: [OBV] Fix gdbtk/generic/gdbtk-varobj.c compilation failure Date: Thu, 17 Sep 2009 07:04:00 -0000 Message-ID: <000001ca3765$056ffb90$104ff2b0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2009-q3/txt/msg00044.txt.bz2 Thanks for catching that error, Tom. I still checked that one also as obvious, despite the fact that my error probably means that I was wrong to consider it as obvious in the first place :( =20=20 Pierre Muller Pascal language support maintainer for GDB 2009-09-17 Pierre Muller * generic/gdbtk-varobj.c (variable_children): Initialize new locals used in varobj_list_children function call. Index: generic/gdbtk-varobj.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-varobj.c,v retrieving revision 1.24 diff -u -p -r1.24 gdbtk-varobj.c --- generic/gdbtk-varobj.c 16 Sep 2009 09:46:58 -0000 1.24 +++ generic/gdbtk-varobj.c 17 Sep 2009 06:59:31 -0000 @@ -420,6 +420,9 @@ variable_children (Tcl_Interp *interp, s list =3D Tcl_NewListObj (0, NULL); + from =3D -1; + to =3D -1; + children =3D varobj_list_children (var, &from, &to); for (ix =3D from; ix < to && VEC_iterate (varobj_p, children, ix, child); ++ix) > -----Message d'origine----- > De=A0: insight-owner@sourceware.org [mailto:insight-owner@sourceware.org] > De la part de Tom Tromey > Envoy=E9=A0: Wednesday, September 16, 2009 6:32 PM > =C0=A0: Pierre Muller > Cc=A0: insight@sourceware.org > Objet=A0: Re: [OBV] Fix gdbtk/generic/gdbtk-varobj.c compilation failure >=20 > >>>>> "Pierre" =3D=3D Pierre Muller writes: >=20 > Pierre> + int ix, from, to; >=20 > Pierre> list =3D Tcl_NewListObj (0, NULL); >=20 > Pierre> - children =3D varobj_list_children (var); > Pierre> + children =3D varobj_list_children (var, &from, &to); >=20 > You have to initialize from and to first -- they are in/out parameters. > -1 is the correct initial value to use. >=20 > Tom