From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23777 invoked by alias); 30 Mar 2012 13:32:11 -0000 Received: (qmail 23759 invoked by uid 22791); 30 Mar 2012 13:32:08 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Mar 2012 13:31:46 +0000 Received: from md2.u-strasbg.fr (md2.u-strasbg.fr [IPv6:2001:660:2402::187]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id q2UDVTTI090188 ; Fri, 30 Mar 2012 15:31:29 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms8.u-strasbg.fr [130.79.204.17]) by md2.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id q2UDVSFJ020351 ; Fri, 30 Mar 2012 15:31:29 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id q2UDVR4a083595 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Fri, 30 Mar 2012 15:31:28 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Keith Seitz'" , "'Roland Schwingel'" Cc: References: <4F67221F.2020906@onevision.com> <4F74E9F1.20804@redhat.com> <000701cd0e75$5e028b80$1a07a280$@muller@ics-cnrs.unistra.fr> <4F75B0A9.1030609@redhat.com> In-Reply-To: <4F75B0A9.1030609@redhat.com> Subject: RE: [PATCH] Add missing prototype in gdbtk.c Date: Fri, 30 Mar 2012 13:32:00 -0000 Message-ID: <000a01cd0e79$67954580$36bfd080$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2012-q1/txt/msg00055.txt.bz2 >> Prototypes apparently require (void) instead of (). > >That's interesting... > >> The following patch fixes the problem for mingw32, >> >> Is this patch OK? >> > >Sure, you could consider a clean-up like that obvious. [I try to use the same "rules" gdb uses. It's what I'm >used to.] > >Thank you, Pierre! I wasn't sure about the fact that this is a real Prototype requirement or not, so I wanted to ask anyway... Patch committed. Roland, could you please confirm that this also works for mingw64. By the way, I got a working insight for mingw32, which I was unable to get for a lllloooonnngggg time! A really big thank to Roland for this! Pierre PS: I treid to compiled a mingw64 version of insight, but I get failures here: make[1]: Entering directory `/usr/local/src/gdbcvs/build-insight-mingw64/tcl' make[2]: Entering directory `/usr/local/src/gdbcvs/build-insight-mingw64/tcl/win' x86_64-w64-mingw32-gcc -c -gstabs+ -O0 -D__USE_MINGW_ACCESS -Wall -Wconversion -I"../../../src/tcl/win/../generic" -I" ../../../src/tcl/win" -mwin32 -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" - DPACKAGE_BUGREPORT=\"\" -DHAVE_NO_SEH=1 -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHA VE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DBUILD_tcl ../../../src/tcl/win/../generic/tclCmdAH.c -o tclCmdAH.o ../../../src/tcl/win/../generic/tclCmdAH.c: In function 'Tcl_FileObjCmd': ../../../src/tcl/win/../generic/tclCmdAH.c:827:18: error: storage size of 'buf' isn't known ../../../src/tcl/win/../generic/tclCmdAH.c:827:18: warning: unused variable 'buf' ../../../src/tcl/win/../generic/tclCmdAH.c:921:18: error: storage size of 'buf' isn't known ../../../src/tcl/win/../generic/tclCmdAH.c:921:18: warning: unused variable 'buf' ../../../src/tcl/win/../generic/tclCmdAH.c:935:18: error: storage size of 'buf' isn't known ../../../src/tcl/win/../generic/tclCmdAH.c:935:18: warning: unused variable 'buf' ../../../src/tcl/win/../generic/tclCmdAH.c:1050:18: error: storage size of 'buf' isn't known ../../../src/tcl/win/../generic/tclCmdAH.c:1050:18: warning: unused variable 'buf' ../../../src/tcl/win/../generic/tclCmdAH.c:1063:18: error: storage size of 'buf' isn't known ../../../src/tcl/win/../generic/tclCmdAH.c:1063:18: warning: unused variable 'buf' ../../../src/tcl/win/../generic/tclCmdAH.c:1138:18: error: storage size of 'buf' isn't known ../../../src/tcl/win/../generic/tclCmdAH.c:1138:18: warning: unused variable 'buf' ../../../src/tcl/win/../generic/tclCmdAH.c:1222:4: warning: conversion to 'size_t' from 'int' may change the sign of the result ../../../src/tcl/win/../generic/tclCmdAH.c:1258:18: error: storage size of 'buf' isn't known ../../../src/tcl/win/../generic/tclCmdAH.c:1258:18: warning: unused variable 'buf' ../../../src/tcl/win/../generic/tclCmdAH.c:1279:18: error: storage size of 'buf' isn't known ../../../src/tcl/win/../generic/tclCmdAH.c:1279:18: warning: unused variable 'buf' ../../../src/tcl/win/../generic/tclCmdAH.c:1348:18: error: storage size of 'buf' isn't known ../../../src/tcl/win/../generic/tclCmdAH.c:1348:18: warning: unused variable 'buf' ../../../src/tcl/win/../generic/tclCmdAH.c: In function 'StoreStatData': ../../../src/tcl/win/../generic/tclCmdAH.c:1514:5: error: dereferencing pointer to incomplete type ../../../src/tcl/win/../generic/tclCmdAH.c:1520:5: error: dereferencing pointer to incomplete type ../../../src/tcl/win/../generic/tclCmdAH.c:1521:5: error: dereferencing pointer to incomplete type ../../../src/tcl/win/../generic/tclCmdAH.c:1522:5: error: dereferencing pointer to incomplete type ../../../src/tcl/win/../generic/tclCmdAH.c:1523:5: error: dereferencing pointer to incomplete type ../../../src/tcl/win/../generic/tclCmdAH.c:1524:5: error: dereferencing pointer to incomplete type ../../../src/tcl/win/../generic/tclCmdAH.c:1528:5: error: dereferencing pointer to incomplete type ../../../src/tcl/win/../generic/tclCmdAH.c:1529:5: error: dereferencing pointer to incomplete type ../../../src/tcl/win/../generic/tclCmdAH.c:1530:5: error: dereferencing pointer to incomplete type ../../../src/tcl/win/../generic/tclCmdAH.c:1531:36: error: dereferencing pointer to incomplete type ../../../src/tcl/win/../generic/tclCmdAH.c: In function 'Tcl_ForeachObjCmd': ../../../src/tcl/win/../generic/tclCmdAH.c:1739:2: warning: conversion to 'long long unsigned int' from 'int' may change the sign of the result ../../../src/tcl/win/../generic/tclCmdAH.c:1739:2: warning: conversion to 'unsigned int' from 'long long unsigned int' may alter its value ../../../src/tcl/win/../generic/tclCmdAH.c:1755:2: warning: conversion to 'long long unsigned int' from 'int' may change the sign of the result ../../../src/tcl/win/../generic/tclCmdAH.c:1755:2: warning: conversion to 'unsigned int' from 'long long unsigned int' may alter its value ../../../src/tcl/win/../generic/tclCmdAH.c:1756:2: warning: conversion to 'long long unsigned int' from 'int' may change the sign of the result ../../../src/tcl/win/../generic/tclCmdAH.c:1756:2: warning: conversion to 'unsigned int' from 'long long unsigned int' may alter its value ../../../src/tcl/win/../generic/tclCmdAH.c:1757:2: warning: conversion to 'long long unsigned int' from 'int' may change the sign of the result ../../../src/tcl/win/../generic/tclCmdAH.c:1757:2: warning: conversion to 'unsigned int' from 'long long unsigned int' may alter its value ../../../src/tcl/win/../generic/tclCmdAH.c:1758:2: warning: conversion to 'long long unsigned int' from 'int' may change the sign of the result ../../../src/tcl/win/../generic/tclCmdAH.c:1758:2: warning: conversion to 'unsigned int' from 'long long unsigned int' may alter its value ../../../src/tcl/win/../generic/tclCmdAH.c:1759:2: warning: conversion to 'long long unsigned int' from 'int' may change the sign of the result ../../../src/tcl/win/../generic/tclCmdAH.c:1759:2: warning: conversion to 'unsigned int' from 'long long unsigned int' may alter its value ../../../src/tcl/win/../generic/tclCmdAH.c: In function 'Tcl_FormatObjCmd': ../../../src/tcl/win/../generic/tclCmdAH.c:2028:6: warning: conversion to 'int' from 'long long int' may alter its value ../../../src/tcl/win/../generic/tclCmdAH.c:2058:6: warning: conversion to 'int' from 'long unsigned int' may change the sign of the result ../../../src/tcl/win/../generic/tclCmdAH.c:2098:6: warning: conversion to 'int' from 'long unsigned int' may change the sign of the result ../../../src/tcl/win/../generic/tclCmdAH.c:2141:6: warning: conversion to 'int' from 'long unsigned int' may change the sign of the result ../../../src/tcl/win/../generic/tclCmdAH.c:2230:3: warning: conversion to 'int' from 'long long int' may alter its value ../../../src/tcl/win/../generic/tclCmdAH.c:2346:7: warning: conversion to 'int' from 'long long int' may alter its value Makefile:423: recipe for target `tclCmdAH.o' failed make[2]: *** [tclCmdAH.o] Error 1 make[2]: Leaving directory `/usr/local/src/gdbcvs/build-insight-mingw64/tcl/win' Makefile:15: recipe for target `all' failed make[1]: *** [all] Error 2 make[1]: Leaving directory `/usr/local/src/gdbcvs/build-insight-mingw64/tcl' Makefile:7209: recipe for target `all-tcl' failed make: *** [all-tcl] Error 2