From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3032 invoked by alias); 7 Jul 2009 12:49:32 -0000 Received: (qmail 2965 invoked by uid 22791); 7 Jul 2009 12:49:31 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.154) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 07 Jul 2009 12:49:23 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n67CnIoj072190 ; Tue, 7 Jul 2009 14:49:18 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402:d::11]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n67CnI2T004328 ; Tue, 7 Jul 2009 14:49:18 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n67CnILh087342 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Tue, 7 Jul 2009 14:49:18 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Ulrich Weigand'" Cc: , References: <200906091517.n59FHee6030279@d12av02.megacenter.de.ibm.com> from "Ulrich Weigand" at Jun 09, 2009 05:17:40 PM <200907021716.n62HG5WD005817@d12av02.megacenter.de.ibm.com> In-Reply-To: <200907021716.n62HG5WD005817@d12av02.megacenter.de.ibm.com> Subject: [RFC] Insight build problem: was [06/15] Per-breakpoint architecture support Date: Tue, 07 Jul 2009 12:49:00 -0000 Message-ID: <001801c9ff01$5b1ae830$1150b890$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2009-q3/txt/msg00013.txt.bz2 Ulrich, your patch made a unlogged change to set_raw_breakpoint: > =================================================================== > --- gdb-head.orig/gdb/breakpoint.c > +++ gdb-head/gdb/breakpoint.c > @@ -20,6 +20,7 @@ > along with this program. If not, see > . */ > > #include "defs.h" > +#include "arch-utils.h" > #include > #include "hashtab.h" > #include "symtab.h" > @@ -104,13 +105,16 @@ static void break_command_1 (char *, int > > static void mention (struct breakpoint *); > > -struct breakpoint *set_raw_breakpoint (struct symtab_and_line, enum > bptype); > +static struct breakpoint *set_raw_breakpoint (struct gdbarch *gdbarch, > + struct symtab_and_line, > + enum bptype); This seems harmless as the function is not in any header, but this function is used in gdbtk sources. I don't really know if gdbtk failures qualify for patches as such, but it seems to me that it would be difficult to change the gdbtk-bp.c code to avoid using this function. Is this failure a sufficient reason to accept this patch or should we go another route (maybe add set_raw_breakpoint to breakpoint.h header ?). Pierre Muller Pascal language support maintainer for GDB 2009-07-07 Pierre Muller * breakpoint.c (set_raw_breakpoint): Remove static modifier. Index: breakpoint.c =================================================================== RCS file: /cvs/src/src/gdb/breakpoint.c,v retrieving revision 1.412 diff -u -p -r1.412 breakpoint.c --- breakpoint.c 2 Jul 2009 17:21:05 -0000 1.412 +++ breakpoint.c 7 Jul 2009 12:45:41 -0000 @@ -105,7 +105,8 @@ static void break_command_1 (char *, int static void mention (struct breakpoint *); -static struct breakpoint *set_raw_breakpoint (struct gdbarch *gdbarch, +/* This function is used in gdbtk sources and thus can not be made static. */ +struct breakpoint *set_raw_breakpoint (struct gdbarch *gdbarch, struct symtab_and_line, enum bptype); @@ -4396,8 +4397,9 @@ static void free_bp_location (struct bp_ /* Helper to set_raw_breakpoint below. Creates a breakpoint that has type BPTYPE and has no locations as yet. */ +/* This function is used in gdbtk sources and thus can not be made static. */ -static struct breakpoint * +struct breakpoint * set_raw_breakpoint_without_location (struct gdbarch *gdbarch, enum bptype bptype) { @@ -4480,7 +4482,7 @@ get_sal_arch (struct symtab_and_line sal prior to completing the initialization of the breakpoint. If this should happen, a bogus breakpoint will be left on the chain. */ -static struct breakpoint * +struct breakpoint * set_raw_breakpoint (struct gdbarch *gdbarch, struct symtab_and_line sal, enum bptype bptype) {