From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31652 invoked by alias); 7 May 2008 09:51:50 -0000 Received: (qmail 31639 invoked by uid 22791); 7 May 2008 09:51:48 -0000 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.153) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 07 May 2008 09:51:19 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id m479pFkd007753 for ; Wed, 7 May 2008 11:51:15 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402::142]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id m479pFC4007484 for ; Wed, 7 May 2008 11:51:15 +0200 (CEST) Received: from d620muller (laocoon.u-strasbg.fr [130.79.112.72]) by mailserver.u-strasbg.fr (8.13.8/jtpda-5.5pre1) with ESMTP id m479pCPL003544 for ; Wed, 7 May 2008 11:51:15 +0200 (CEST) From: "Pierre Muller" To: Subject: [RFA] Fix compilation failure due to val_print change. Date: Wed, 07 May 2008 09:51:00 -0000 Message-ID: <008601c8b027$e35b3e40$aa11bac0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Content-Language: en-us X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (mailhost.u-strasbg.fr [IPv6:2001:660:2402::153]); Wed, 07 May 2008 11:51:15 +0200 (CEST) X-Virus-Status: Clean X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2008-q2/txt/msg00056.txt.bz2 Hi, I am new to this list, but not to GDB, I am maintainer of the pascal language support for gdb. I am regularly compiling GDB for cygwin, which by default also compiles the gdbtk subdirectory. According to Daniel, changes in that directory depend on the insight team. Thus I submit here a patch that fixes compilation failure in trunk due to a recent change in val_print function see: http://sourceware.org/ml/gdb-cvs/2008-05/msg00089.html This patch simply uses current_language as additional argument. Can I check this in? Is it the same CVS repository as GDB? Is my GDB copyright paper ok for this? Pierre Muller Pascal language support maintainer for GDB ChangeLog entry: 2008-05-07 Pierre Muller Update uses of val_print functions with additional language argument. generic/gdbtk-cmds.c: Add "language.h" include. (gdb_eval): Add current_language as new arg of val_print. generic/gdbtk-register.c: Add "language.h" include. (get_register): Add current_language as new arg of val_print. generic/gdbtk-wrapper.c: Add "language.h" include. (wrap_val_print): Add current_language as new arg of val_print. Index: generic/gdbtk-cmds.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v retrieving revision 1.99 diff -u -p -r1.99 gdbtk-cmds.c --- generic/gdbtk-cmds.c 21 Apr 2008 20:14:48 -0000 1.99 +++ generic/gdbtk-cmds.c 7 May 2008 09:30:22 -0000 @@ -41,6 +41,7 @@ #include "value.h" #include "varobj.h" #include "exceptions.h" +#include "language.h" /* tcl header files includes varargs.h unless HAS_STDARG is defined, but gdb uses stdarg.h, so make sure HAS_STDARG is defined. */ @@ -631,7 +632,7 @@ gdb_eval (ClientData clientData, Tcl_Int make_cleanup_ui_file_delete (stb); val_print (value_type (val), value_contents (val), value_embedded_offset (val), VALUE_ADDRESS (val), - stb, format, 0, 0, 0); + stb, format, 0, 0, 0, current_language); result = ui_file_xstrdup (stb, &dummy); Tcl_SetObjResult (interp, Tcl_NewStringObj (result, -1)); xfree (result); Index: generic/gdbtk-register.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-register.c,v retrieving revision 1.34 diff -u -p -r1.34 gdbtk-register.c --- generic/gdbtk-register.c 7 Mar 2008 08:03:19 -0000 1.34 +++ generic/gdbtk-register.c 7 May 2008 09:30:23 -0000 @@ -25,6 +25,7 @@ #include "value.h" #include "target.h" #include "gdb_string.h" +#include "language.h" #include #include "gdbtk.h" @@ -333,11 +334,11 @@ get_register (int regnum, map_arg arg) gdbarch_register_name (current_gdbarch, regnum)) == 0)) { val_print (FIELD_TYPE (TYPE_FIELD (reg_vtype, 0)), buffer, 0, 0, - stb, format, 1, 0, Val_pretty_default); + stb, format, 1, 0, Val_pretty_default, current_language); } else val_print (reg_vtype, buffer, 0, 0, - stb, format, 1, 0, Val_pretty_default); + stb, format, 1, 0, Val_pretty_default, current_language); } res = ui_file_xstrdup (stb, &dummy); Index: generic/gdbtk-wrapper.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-wrapper.c,v retrieving revision 1.15 diff -u -p -r1.15 gdbtk-wrapper.c --- generic/gdbtk-wrapper.c 7 Mar 2008 08:03:19 -0000 1.15 +++ generic/gdbtk-wrapper.c 7 May 2008 09:30:23 -0000 @@ -24,6 +24,7 @@ #include "varobj.h" #include "block.h" #include "exceptions.h" +#include "language.h" #include "gdbtk-wrapper.h" /* @@ -218,7 +219,7 @@ wrap_val_print (char *a) pretty = (enum val_prettyprint) (*args)->args[7].integer; val_print (type, valaddr, 0, address, stream, format, deref_ref, - recurse, pretty); + recurse, pretty, current_language); return 1; }