From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19309 invoked by alias); 15 Nov 2012 10:11:03 -0000 Received: (qmail 19297 invoked by uid 22791); 15 Nov 2012 10:11:02 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT,TW_BT,TW_DB X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.154) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Nov 2012 10:10:53 +0000 Received: from md15.u-strasbg.fr (md15.u-strasbg.fr [130.79.200.204]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qAFAAksp074797 ; Thu, 15 Nov 2012 11:10:46 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms15.u-strasbg.fr [130.79.204.115]) by md15.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qAFAAjZX001278 ; Thu, 15 Nov 2012 11:10:45 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qAFAAiEl000607 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Thu, 15 Nov 2012 11:10:45 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Tom Tromey'" , "'Keith Seitz'" Cc: References: <87390c2dy8.fsf@fleche.redhat.com> In-Reply-To: <87390c2dy8.fsf@fleche.redhat.com> Subject: RE: don't check uselessly for headers Date: Thu, 15 Nov 2012 10:11:00 -0000 Message-ID: <00c401cdc319$7ab51960$701f4c20$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2012-q4/txt/msg00015.txt.bz2 Hi Tom, gdbtk directory is still also using HAVE_CTYPE_H... This needs a fix to restore compilation for insight. Keith, Could you test and check this patch in if it works, I have no system on which I can compile insight currently :( Pierre Muller Index: ChangeLog =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/gdbtk/ChangeLog,v retrieving revision 1.485 diff -u -p -r1.485 ChangeLog --- ChangeLog 10 Nov 2012 18:09:30 -0000 1.485 +++ ChangeLog 15 Nov 2012 10:07:00 -0000 @@ -1,3 +1,9 @@ +2012-11-15 Pierre Muller + + Adapt to change in gdb/configure.ac + Don't check for ctype.h, time.h. + * generic/gdbtk-cmds.c: Don't use HAVE_CTYPE_H. + 2012-11-10 Keith Seitz * generic/gdbtk-bp.c (breakpoint_notify): Fix logic error cvs diff: Diffing generic Index: generic/gdbtk-cmds.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v retrieving revision 1.129 diff -u -p -r1.129 gdbtk-cmds.c --- generic/gdbtk-cmds.c 10 Oct 2012 17:28:03 -0000 1.129 +++ generic/gdbtk-cmds.c 15 Nov 2012 10:07:01 -0000 @@ -88,9 +88,7 @@ # endif #endif -#ifdef HAVE_CTYPE_H #include /* for isprint() */ -#endif #ifdef _WIN32 #include /* For gdb_list_processes() */ =20=20 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Tom Tromey > Envoy=E9=A0: mercredi 14 novembre 2012 20:16 > =C0=A0: gdb-patches@sourceware.org > Objet=A0: FYI: don't check uselessly for headers >=20 > I'm checking this in. >=20 > While looking at importing more of gnulib, I noticed that gdb's > configure script is checking for ctype.h and time.h -- but there are no > uses of HAVE_TIME_H and only a single use of HAVE_CTYPE_H. So, per the > existing comment, these checks are useless. >=20 > This patch removes the checks and updates the one place using > HAVE_CTYPE_H. >=20 > Tested by rebuilding. >=20 > Tom >=20 > 2012-11-14 Tom Tromey >=20 > * configure, config.in: Rebuild. > * configure.ac: Don't check for ctype.h, time.h. > * expprint.c: Don't use HAVE_CTYPE_H. >=20 > Index: configure.ac > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/src/src/gdb/configure.ac,v > retrieving revision 1.186 > diff -u -r1.186 configure.ac > --- configure.ac 2 Nov 2012 18:53:54 -0000 1.186 > +++ configure.ac 14 Nov 2012 19:12:05 -0000 > @@ -1075,8 +1075,6 @@ > AC_HEADER_STAT > AC_HEADER_STDC > # elf_hp.h is for HP/UX 64-bit shared library support. > -# FIXME: kettenis/20030102: In most cases we include these (ctype.h, > time.h) > -# unconditionally, so what's the point in checking these? > AC_CHECK_HEADERS([nlist.h machine/reg.h poll.h sys/poll.h proc_service.h \ > thread_db.h signal.h stddef.h \ > stdlib.h string.h memory.h strings.h sys/fault.h \ > @@ -1084,7 +1082,7 @@ > sys/resource.h sys/procfs.h sys/ptrace.h ptrace.h \ > sys/reg.h sys/debugreg.h sys/select.h sys/syscall.h \ > sys/types.h sys/wait.h wait.h termios.h termio.h \ > - sgtty.h unistd.h elf_hp.h ctype.h time.h locale.h \ > + sgtty.h unistd.h elf_hp.h locale.h \ > dlfcn.h sys/socket.h sys/un.h]) > AC_CHECK_HEADERS(link.h, [], [], > [#if HAVE_SYS_TYPES_H > Index: expprint.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/src/src/gdb/expprint.c,v > retrieving revision 1.63 > diff -u -r1.63 expprint.c > --- expprint.c 13 Nov 2012 09:46:10 -0000 1.63 > +++ expprint.c 14 Nov 2012 19:12:06 -0000 > @@ -33,9 +33,7 @@ > #include "gdb_assert.h" > #include "valprint.h" >=20 > -#ifdef HAVE_CTYPE_H > #include > -#endif >=20 > void > print_expression (struct expression *exp, struct ui_file *stream)