Patches for RDI stop code and general features

["Tim Chick" <TChick@virata.com>]

A while ago this was disscussed, and Fernando said he would
put in the RDI stop code. This hasn't happened as of the 10/10
snapshot, I'm not moaning, just maybe a reminder :-)

Since getting insight to work with my Jeeni, I have noticed
a few problems:

1. If you specify a symbol file on the command line, and
   it can't be opened, there is no warning that the file
   could not be opened.

2. I can't delete my breakpoints with the GUI, I have to
   use the console. If I try to delete a breakpoint the gui
   gives a popup:
   Error: No breakpoint at <sourcefile>.s:<line>

   This only occurs in breakpoints in assembly code.

3. Disasembly and mixed source and assembly view. On
   the ARM using the Jeeni it sometimes gets the disassembly
   wrong.

If I were to try and fix these, how would I supply patches for
approval? What program should I use to produce these patch files?

Thanks,
Tim


----- Original Message -----
From: "Fernando Nasser" <fnasser@cygnus.com>
To: "Grant Edwards" <grante@visi.com>
Cc: <insight@sourceware.cygnus.com>
Sent: Tuesday, September 12, 2000 10:04 PM
Subject: Re: Patches for source path and SIGINT warning


> Grant,
>
> I would like to fix the path thing using the libgui call instead of
> modifying Tcl.  I don't know when I will be given time to work on that but
> I will take note of it.  Of course, you already got your problem solved
and
> anyone else who needs it in a hurry can use your patch.  Thanks for dooing
it.
>
> Of course, as you say, we must not incorporate the SIGINT ignore patch.
Again,
> people who are doing exclusively RDI debugging can use your patch.
> I am tempted to get rid of that window and printing the signal received
message
> in the status line...
>
> Regards,
> Fernando
>
> P.S.: I think I will add your RDI stop code regardless.  Is it OK?
>
>
> Grant Edwards wrote:
> >
> > Attached are two patches against Insight-5.0.
> >
> > The first fixes the problem where the source window couldn't
> > open the source file because the path in the debugging info is
> > cygwin-style.
> >
> > Disclaimer: Somebody argued that this is the wrong way to fix
> >             it, but I didn't see any suggested right way, so
> >             those of us with work to do to will just have to
> >             suffer under the philosphical burden.  ;)
> >
> > The second disables the pop-up warning dialog about "target
> > received SIGINT" that happens when you press the "stop" button
> > to stop execution of an RDI target.
> >
> > Warning: it disables the SIGINT dialog completely, regardless
> >          of the target.  For the RDI target, the only source of
> >          SIGINT is a user-requested stop, so it's no big deal.
> >          For other targets, disabling this dialog may result in
> >          lossage of useful information.
> >
> >          So, there needs to be a more elegant solution, but I don't
> >          know enough Tcl to figure one out.
> >
> > Both of these patches (along with the gdb patches to enable the
> > "stop" button) are available at
> >
> >   ftp://ftp.visi.com/users/grante/gdb-rdi-patches/5.0
> >
>
> --
> Fernando Nasser
> Red Hat - Toronto                       E-Mail:  fnasser@cygnus.com
> 2323 Yonge Street, Suite #300           Tel:  416-482-2661 ext. 311
> Toronto, Ontario   M4P 2C9              Fax:  416-482-6299
>