[PATCH] Add type parameter to set_raw_breakpoint()

[PATCH] Add type parameter to set_raw_breakpoint()

[Kevin Buettner]

I've just committing the following changes.  For more information on the
corresponding changes to breakpoint.c, see:

    http://sources.redhat.com/ml/gdb-patches/2001-05/msg00204.html

Please note that set_raw_breakpoint() ought to either be declared
extern in breakpoint.h or calls to this function should be removed from
gdbtk-bp.c so that it can be made static in breakpoint.c.

	* generic/gdbtk-bp.c (set_raw_breakpoint): Revise declaration
	to match the recently changed declaration in breakpoint.c. 
	Update all callers.

Index: gdbtk/generic/gdbtk-bp.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-bp.c,v
retrieving revision 1.4
diff -u -p -r1.4 gdbtk-bp.c
--- gdbtk-bp.c	2001/05/11 14:33:10	1.4
+++ gdbtk-bp.c	2001/05/11 19:56:46
@@ -66,7 +66,8 @@ char *bpdisp[] =
  * at some point make these static in breakpoint.c and move GUI code there
  */
 
-extern struct breakpoint *set_raw_breakpoint (struct symtab_and_line sal);
+extern struct breakpoint *set_raw_breakpoint (struct symtab_and_line sal,
+					      enum bptype bp_type);
 extern void set_breakpoint_count (int);
 extern int breakpoint_count;
 
@@ -468,10 +469,9 @@ gdb_set_bp (clientData, interp, objc, ob
     return TCL_ERROR;
 
   sal.section = find_pc_overlay (sal.pc);
-  b = set_raw_breakpoint (sal);
+  b = set_raw_breakpoint (sal, bp_breakpoint);
   set_breakpoint_count (breakpoint_count + 1);
   b->number = breakpoint_count;
-  b->type = bp_breakpoint;
   b->disposition = disp;
   b->thread = thread;
 
@@ -549,10 +549,9 @@ gdb_set_bp_addr (ClientData clientData, 
 
   sal = find_pc_line (addr, 0);
   sal.pc = addr;
-  b = set_raw_breakpoint (sal);
+  b = set_raw_breakpoint (sal, bp_breakpoint);
   set_breakpoint_count (breakpoint_count + 1);
   b->number = breakpoint_count;
-  b->type = bp_breakpoint;
   b->disposition = disp;
   b->thread = thread;
 

Re: [PATCH] Add type parameter to set_raw_breakpoint()

[Andrew Cagney]

> I've just committing the following changes.  For more information on the
> corresponding changes to breakpoint.c, see:
> 
>     http://sources.redhat.com/ml/gdb-patches/2001-05/msg00204.html
> 
> Please note that set_raw_breakpoint() ought to either be declared
> extern in breakpoint.h or calls to this function should be removed from
> gdbtk-bp.c so that it can be made static in breakpoint.c.

It should be static.  Insight should instead call the published interface:

/* Create a breakpoint at ADDRESS (a GDB source and line). */
enum gdb_rc gdb_breakpoint (char *address, char *condition,
                             int hardwareflag, int tempflag,
                             int thread, int ignore_count);

	Andrew