From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1400 invoked by alias); 19 Dec 2002 01:12:02 -0000 Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sources.redhat.com Received: (qmail 1384 invoked from network); 19 Dec 2002 01:12:01 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by 209.249.29.67 with SMTP; 19 Dec 2002 01:12:01 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gBJ0jYg03475 for ; Wed, 18 Dec 2002 19:45:34 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gBJ1Bn232203 for ; Wed, 18 Dec 2002 20:11:49 -0500 Received: from dragon (romulus-int.sfbay.redhat.com [172.16.27.46]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gBJ1BmL06767 for ; Wed, 18 Dec 2002 20:11:48 -0500 Subject: [patch] regwin highlight fixes From: "Martin M. Hunt" To: "insight@sources.redhat.com" Content-Type: multipart/mixed; boundary="=-9eTHGfqxZ+qGpu0h85qY" Date: Wed, 18 Dec 2002 17:12:00 -0000 Message-Id: <1040260513.15465.1.camel@Dragon> Mime-Version: 1.0 X-SW-Source: 2002-q4/txt/msg00223.txt.bz2 --=-9eTHGfqxZ+qGpu0h85qY Content-Type: text/plain Content-Transfer-Encoding: 7bit Content-length: 399 This improves highlighting of changed values when switching register groups. 2002-12-18 Martin M. Hunt * library/regwin.itb (RegWin::update): When updating, check that a cell still exists before checking its value. (RegWin::_select_group): Clear cells with changed values before changing group. After new group is selected, highlight any changed values still visible. --=-9eTHGfqxZ+qGpu0h85qY Content-Disposition: attachment; filename=p Content-Transfer-Encoding: quoted-printable Content-Type: text/x-patch; name=p; charset=UTF-8 Content-length: 2237 Index: library/regwin.itb =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/gdbtk/library/regwin.itb,v retrieving revision 1.23 diff -p -r1.23 regwin.itb *** library/regwin.itb 17 Dec 2002 20:29:12 -0000 1.23 --- library/regwin.itb 19 Dec 2002 01:08:47 -0000 *************** itcl::body RegWin::_update_register {rn} *** 901,914 **** # ------------------------------------------------------------------ itcl::body RegWin::_select_group {} { set gr [$itk_component(frame).opt get] if {$gr =3D=3D ""} { return } set _group $gr # Clear gdb's change list catch {gdb_reginfo changed} - update "" - _layout_table } =20=20 =20=20 --- 901,930 ---- # ------------------------------------------------------------------ itcl::body RegWin::_select_group {} { set gr [$itk_component(frame).opt get] + debug $gr if {$gr =3D=3D ""} { return } +=20 + # Change anything on the old change list back to normal + foreach r $_change_list { + if {[info exists _cell($r)] && $_cell($r) !=3D "hidden"} { + $itk_component(table) tag cell normal $_cell($r) + } + } +=20 set _group $gr + _layout_table +=20 + # highlight changed registers if they still exist in the new group + foreach r $_change_list { + if {[info exists _cell($r)] && $_cell($r) !=3D "hidden" && $_data($_c= ell($r)) !=3D ""} { + $itk_component(table) tag cell highlight $_cell($r) + } + } +=20 # Clear gdb's change list catch {gdb_reginfo changed} } =20=20 =20=20 *************** itcl::body RegWin::update {event} { *** 999,1005 **** =20=20 # Change anything on the old change list back to normal foreach r $_change_list { ! if {$_cell($r) !=3D "hidden"} { $itk_component(table) tag cell normal $_cell($r) } } --- 1015,1021 ---- =20=20 # Change anything on the old change list back to normal foreach r $_change_list { ! if {[info exists _cell($r)] && $_cell($r) !=3D "hidden"} { $itk_component(table) tag cell normal $_cell($r) } } --=-9eTHGfqxZ+qGpu0h85qY--