From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20034 invoked by alias); 12 Feb 2003 00:39:27 -0000 Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sources.redhat.com Received: (qmail 20027 invoked from network); 12 Feb 2003 00:39:27 -0000 Received: from unknown (HELO mx1.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 12 Feb 2003 00:39:27 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h1C0dRf28058 for ; Tue, 11 Feb 2003 19:39:27 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h1C0dRa12465 for ; Tue, 11 Feb 2003 19:39:27 -0500 Received: from [150.1.200.14] (vpn50-20.rdu.redhat.com [172.16.50.20]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h1C0dQs15921 for ; Tue, 11 Feb 2003 19:39:26 -0500 Subject: [PATCH] Don't update registers with no valid frame From: Keith Seitz To: "insight@sources.redhat.com" Content-Type: multipart/mixed; boundary="=-Thu/ZdPfRtU+mcbWelp+" Organization: Message-Id: <1045010650.1493.37.camel@lindt.uglyboxes.com> Mime-Version: 1.0 Date: Wed, 12 Feb 2003 00:39:00 -0000 X-SW-Source: 2003-q1/txt/msg00108.txt.bz2 --=-Thu/ZdPfRtU+mcbWelp+ Content-Type: text/plain Content-Transfer-Encoding: 7bit Content-length: 398 Hi, This patch should fix a recent internal_error problem that has crept up in recent days. Try opening the Register Window with no process. Oops. Keith ChangeLog 2003-02-11 Keith R Seitz * generic/gdbtk-register.c (register_changed_p): If the selected frame is NULL, do not call frame_register_read, since that will now cause an internal error. --=-Thu/ZdPfRtU+mcbWelp+ Content-Disposition: inline; filename=p Content-Type: text/x-patch; name=p; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-length: 758 Index: gdbtk/generic/gdbtk-register.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-register.c,v retrieving revision 1.14 diff -u -p -r1.14 gdbtk-register.c --- gdbtk/generic/gdbtk-register.c 11 Feb 2003 16:08:38 -0000 1.14 +++ gdbtk/generic/gdbtk-register.c 12 Feb 2003 00:36:34 -0000 @@ -437,7 +437,8 @@ register_changed_p (int regnum, void *ar { char *raw_buffer = alloca (MAX_REGISTER_RAW_SIZE); - if (!frame_register_read (deprecated_selected_frame, regnum, raw_buffer)) + if (deprecated_selected_frame == NULL + || !frame_register_read (deprecated_selected_frame, regnum, raw_buffer)) return; if (memcmp (&old_regs[regnum * MAX_REGISTER_RAW_SIZE], raw_buffer, --=-Thu/ZdPfRtU+mcbWelp+--