From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17664 invoked by alias); 25 Aug 2003 20:51:14 -0000 Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sources.redhat.com Received: (qmail 17657 invoked from network); 25 Aug 2003 20:51:14 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 25 Aug 2003 20:51:14 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h7PKpDl16984 for ; Mon, 25 Aug 2003 16:51:14 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h7PKpDs22536; Mon, 25 Aug 2003 16:51:13 -0400 Received: from [150.1.200.14] (vpn50-67.rdu.redhat.com [172.16.50.67]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h7PKpCTN019933; Mon, 25 Aug 2003 16:51:13 -0400 Subject: Re: Problem with "finish" command in insight. From: Keith Seitz To: Josef Wolf Cc: "insight@sources.redhat.com" In-Reply-To: <20030825203237.GB32349@raven.inka.de> References: <20030822223935.GA29951@raven.inka.de> <1061833167.1581.1.camel@lindt.uglyboxes.com> <20030825203237.GB32349@raven.inka.de> Content-Type: text/plain Organization: Message-Id: <1061844781.1581.46.camel@lindt.uglyboxes.com> Mime-Version: 1.0 Date: Mon, 25 Aug 2003 20:51:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2003-q3/txt/msg00127.txt.bz2 On Mon, 2003-08-25 at 13:32, Josef Wolf wrote: > I have no idea why original gdb-5.3 omitted the cleanups on TYPE_CODE_VOID. > The FIXME indicates that the original autor was unsure about this, too ;-). > This is exactly what triggered my problem. And it seems to exist in the > main gdb program (although I could not trigger it in main gdb, but this might > be by accident). Your patch seem to be more general, but it fixes only > insight and not main gdb. So which patch would be the correct one? Or should > both patches be included? Or better your patch and a similar (generic) patch > for main gdb in addition? My patch fixes insight so that it's main loop behaves the same as the console's command loop. Your patch addresses a slightly different problem: one with gdb. IMO, you should use my patch AND your patch if that fixes gdb. If the finish problem you are seeing in gdb still exists, I recommend filing a bug report in the gdb database and attaching your patch. I'm sure they'd welcome that. Keith