From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <insight-return-5272-listarch-insight=sources.redhat.com@sources.redhat.com>
Received: (qmail 23364 invoked by alias); 28 Apr 2005 17:37:30 -0000
Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:insight-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/insight/>
List-Post: <mailto:insight@sources.redhat.com>
List-Help: <mailto:insight-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: insight-owner@sources.redhat.com
Received: (qmail 23201 invoked from network); 28 Apr 2005 17:37:25 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 28 Apr 2005 17:37:25 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j3SHbPu3012764
	for <insight@sources.redhat.com>; Thu, 28 Apr 2005 13:37:25 -0400
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j3SHbPO23252;
	Thu, 28 Apr 2005 13:37:25 -0400
Received: from localhost.localdomain (sebastian-int.corp.redhat.com [172.16.52.221])
	by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id j3SHbN1K005656;
	Thu, 28 Apr 2005 13:37:24 -0400
Subject: Re: Fix gdbtk build breakage
From: Keith Seitz <keiths@redhat.com>
To: Ben Elliston <bje@au1.ibm.com>
Cc: insight@sources.redhat.com
In-Reply-To: <42703D45.7060106@au.ibm.com>
References: <42703D45.7060106@au.ibm.com>
Content-Type: text/plain
Date: Thu, 28 Apr 2005 17:37:00 -0000
Message-Id: <1114709843.4487.1.camel@lindt.uglyboxes.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-SW-Source: 2005-q2/txt/msg00015.txt.bz2

On Thu, 2005-04-28 at 11:32 +1000, Ben Elliston wrote:
> This fixes a gdbtk build breakage.  Okay for mainline?

Absolutely! I think things like this would fall under the "obvious"
rules that gdb uses. [Okay, I know that officially Insight isn't part of
gdb, but I would like it to be, so I delude myself and use the same
rules they do.]

Thanks!
Keith

> 2005-04-28  Ben Elliston  <bje@au.ibm.com>
> 
> 	* generic/gdbtk-interp.c (gdbtk_interpreter_exec): Return struct
> 	gdb_exception due to the 2005-04-26 renaming of struct exception.
> 	* generic/gdbtk.c (gdbtk_source_start_file): Likewise.
> 
> Index: gdbtk-interp.c
> ===================================================================
> RCS file: /home/bje/src-cvs/src/gdb/gdbtk/generic/gdbtk-interp.c,v
> retrieving revision 1.5
> diff -u -p -r1.5 gdbtk-interp.c
> --- gdbtk-interp.c      18 Jan 2005 00:14:39 -0000      1.5
> +++ gdbtk-interp.c      28 Apr 2005 01:31:08 -0000
> @@ -113,7 +113,7 @@ gdbtk_interpreter_display_prompt_p (void
>    return 1;
>  }
> 
> -static struct exception
> +static struct gdb_exception
>  gdbtk_interpreter_exec (void *data, const char *command_str)
>  {
>    return exception_none;
> Index: gdbtk.c
> ===================================================================
> RCS file: /home/bje/src-cvs/src/gdb/gdbtk/generic/gdbtk.c,v
> retrieving revision 1.41
> diff -u -p -r1.41 gdbtk.c
> --- gdbtk.c     25 Feb 2005 22:23:25 -0000      1.41
> +++ gdbtk.c     28 Apr 2005 01:31:08 -0000
> @@ -635,7 +635,7 @@ gdbtk_find_main";
>          get to see the failure reason.  */
>        MessageBox (NULL, msg, NULL, MB_OK | MB_ICONERROR | MB_TASKMODAL);
>        {
> -        struct exception e;
> +        struct gdb_exception e;
>          e.reason  = RETURN_ERROR;
>          e.error   = GENERIC_ERROR;
>          e.message = msg;