[PATCH]: Ignore warnings (was Re: GDB Internal Errors/other messages.)

[Keith Seitz <keiths@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

On Mon, 2005-06-06 at 17:48 -0700, Keith Seitz wrote:
> So, you've convinced me that your previous patch should be used in some
> form. I'll check that in now, rerouting the message to the console
> window. If you want to do the work of the whole warning window thing,
> just submit when you're done.

I've checked in the attached patch which does this for any warning that
starts with "Internal error" or "incomplete CFI". There are probably a
bunch more.

It reroutes the messages to the console.

Keith

ChangeLog
2005-06-06  Keith Seitz  <keiths@redhat.com>

        * library/interface.tcl (gdbtk_tcl_fputs_error): gdbtk_state is in the global
        namespace. Fix references.
        (gdbtk_tcl_fputs_log): Likewise.

        From Steven Johnson  <johnson@sakuraindustries.com>:
        * library/interface.tcl (gdbtk_tcl_warning): Filter some basic warnings
        from gdb - "incomplete CFI.." and "Internal error".



[-- Attachment #2: ignore-warnings.patch --]
[-- Type: text/x-patch, Size: 1592 bytes --]

Index: library/interface.tcl
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/interface.tcl,v
retrieving revision 1.53
diff -u -p -r1.53 interface.tcl
--- library/interface.tcl	27 Aug 2004 23:13:14 -0000	1.53
+++ library/interface.tcl	7 Jun 2005 01:07:19 -0000
@@ -365,6 +365,11 @@ proc gdbtk_tcl_warning {message} {
 
   switch -regexp $message {
         "Unable to find dynamic linker breakpoint function.*" {return}
+	"Internal error.*" { gdbtk_tcl_fputs_error $message }
+        "incomplete CFI.*" {
+	    puts "here i am"
+	    gdbtk_tcl_fputs_error $message
+	}
         default {show_warning $message}
        }
 }
@@ -435,7 +440,8 @@ proc echo {args} {
 # PROC: gdbtk_tcl_fputs_error - write an error message
 # ------------------------------------------------------------------
 proc gdbtk_tcl_fputs_error {message} {
-  if {[info exists gdbtk_state(console)] && $::gdbtk_state(console) != ""} {
+  if {[info exists ::gdbtk_state(console)] && $::gdbtk_state(console) != ""} {
+      puts "I am here, too"
     $::gdbtk_state(console) insert $message err_tag
     update
   }
@@ -445,7 +451,7 @@ proc gdbtk_tcl_fputs_error {message} {
 # PROC: gdbtk_tcl_fputs_log - write a log message
 # ------------------------------------------------------------------
 proc gdbtk_tcl_fputs_log {message} {
-  if {[info exists gdbtk_state(console)] && $::gdbtk_state(console) != ""} {
+  if {[info exists ::gdbtk_state(console)] && $::gdbtk_state(console) != ""} {
     $::gdbtk_state(console) insert $message log_tag
     update
   }