From: James Ingham <jingham@cygnus.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: "Insight (GDB GUI)" <insight@sourceware.cygnus.com>
Subject: For review: delete varargs code from gdbtk
Date: Sun, 08 Aug 1999 11:54:00 -0000 [thread overview]
Message-ID: <14253.53954.813703.619010@leda.cygnus.com> (raw)
In-Reply-To: <37ACE1C9.427A2C5D@cygnus.com>
Andrew,
Go for it...
Jim
> Hello,
>
> The attached patch eleminates varargs code from GDBtk.
>
> Comments,
> AndrewIndex: gdbtk-cmds.c
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/gdb/gdbtk-cmds.c,v
> retrieving revision 2.54
> diff -p -r2.54 gdbtk-cmds.c
> *** gdbtk-cmds.c 1999/08/03 00:33:48 2.54
> --- gdbtk-cmds.c 1999/08/08 01:41:50
> ***************
> *** 45,55 ****
> #include "guitcl.h"
> #include "gdbtk.h"
>
> - #ifdef ANSI_PROTOTYPES
> - #include <stdarg.h>
> - #else
> - #include <varargs.h>
> - #endif
> #include <signal.h>
> #include <fcntl.h>
> #include <unistd.h>
> --- 45,50 ----
> *************** wrapped_call (opaque_args)
> *** 535,560 ****
> */
>
> static void
> - #ifdef ANSI_PROTOTYPES
> sprintf_append_element_to_obj (Tcl_Obj * objp, char *format,...)
> - #else
> - sprintf_append_element_to_obj (va_alist)
> - va_dcl
> - #endif
> {
> va_list args;
> char buf[1024];
>
> - #ifdef ANSI_PROTOTYPES
> va_start (args, format);
> - #else
> - Tcl_Obj *objp;
> - char *format;
> -
> - va_start (args);
> - dsp = va_arg (args, Tcl_Obj *);
> - format = va_arg (args, char *);
> - #endif
>
> vsprintf (buf, format, args);
>
> --- 530,541 ----
> Index: gdbtk.c
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/gdb/gdbtk.c,v
> retrieving revision 2.137
> diff -p -r2.137 gdbtk.c
> *** gdbtk.c 1999/07/16 20:38:21 2.137
> --- gdbtk.c 1999/08/08 01:41:51
> ***************
> *** 46,56 ****
> #include "guitcl.h"
> #include "gdbtk.h"
>
> - #ifdef ANSI_PROTOTYPES
> - #include <stdarg.h>
> - #else
> - #include <varargs.h>
> - #endif
> #include <signal.h>
> #include <fcntl.h>
> #include <unistd.h>
> --- 46,51 ----
prev parent reply other threads:[~1999-08-08 11:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-08-07 18:48 Andrew Cagney
1999-08-08 11:54 ` James Ingham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14253.53954.813703.619010@leda.cygnus.com \
--to=jingham@cygnus.com \
--cc=ac131313@cygnus.com \
--cc=insight@sourceware.cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).