From mboxrd@z Thu Jan  1 00:00:00 1970
From: James Ingham <jingham@cygnus.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: "Insight (GDB GUI)" <insight@sourceware.cygnus.com>
Subject: Re: RFA: Some -Wmissing-prototypes tweeks
Date: Mon, 20 Sep 1999 10:19:00 -0000
Message-id: <14310.27869.771979.648120@leda.cygnus.com>
References: <37E5F0A8.948F5382@cygnus.com>
X-SW-Source: 1999-q3/msg00137.html

Andrew,

These are great!  Check 'em in.

JIm

 > Hello,
 > 
 > The attached tidies up some -Wmissing-prototypes warnings.
 > 
 > Ok?
 > 
 > 	Andrew
 > 
 > 
 > Mon Sep 20 18:03:28 1999  Andrew Cagney  <cagney@b1.cygnus.com>
 > 
 > 	* gdbtk-variable.c (new_root_variable): Fix prototype declaration.
 > 	* gdbtk.c (_initialize_gdbtk): Add declaration.
 > 	* gdbtk-cmds.c (tracepoint_exists): Make static.  Add declaration.
 > 	* gdbtk.c (gdbtk_add_hooks): Move declaration from here.
 > 	* gdbtk.h (gdbtk_add_hooks): To here.Index: gdbtk-cmds.c
 > ===================================================================
 > RCS file: /cvs/cvsfiles/devo/gdb/gdbtk-cmds.c,v
 > retrieving revision 2.58
 > diff -p -r2.58 gdbtk-cmds.c
 > *** gdbtk-cmds.c	1999/09/19 06:12:27	2.58
 > --- gdbtk-cmds.c	1999/09/20 08:19:09
 > ***************
 > *** 59,64 ****
 > --- 59,65 ----
 >   #include <sys/time.h>
 >   
 >   static void setup_architecture_data PARAMS ((void));
 > + static int tracepoint_exists (char *args);
 >   
 >   /* This structure filled in call_wrapper and passed to
 >      the wrapped call function.
 > *************** gdb_get_tracepoint_list (clientData, int
 > *** 2038,2044 ****
 >   }
 >   
 >   /* returns -1 if not found, tracepoint # if found */
 > ! int
 >   tracepoint_exists (char *args)
 >   {
 >     struct tracepoint *tp;
 > --- 2039,2045 ----
 >   }
 >   
 >   /* returns -1 if not found, tracepoint # if found */
 > ! static int
 >   tracepoint_exists (char *args)
 >   {
 >     struct tracepoint *tp;
 > Index: gdbtk-variable.c
 > ===================================================================
 > RCS file: /cvs/cvsfiles/devo/gdb/gdbtk-variable.c,v
 > retrieving revision 2.12
 > diff -p -r2.12 gdbtk-variable.c
 > *** gdbtk-variable.c	1999/08/05 15:53:57	2.12
 > --- gdbtk-variable.c	1999/09/20 08:19:14
 > *************** static enum vlanguage variable_language 
 > *** 305,311 ****
 >   
 >   static gdb_variable *new_variable PARAMS ((void));
 >   
 > ! static gdb_variable *new_root_variable PARAMS (());
 >   
 >   static void free_variable PARAMS ((gdb_variable *var));
 >   
 > --- 305,311 ----
 >   
 >   static gdb_variable *new_variable PARAMS ((void));
 >   
 > ! static gdb_variable *new_root_variable (void);
 >   
 >   static void free_variable PARAMS ((gdb_variable *var));
 >   
 > *************** new_variable ()
 > *** 1687,1693 ****
 >   
 >   /* Allocate memory and initialize a new root variable */
 >   static gdb_variable *
 > ! new_root_variable ()
 >   {
 >     gdb_variable *var = new_variable ();
 >     var->root = (struct variable_root *) xmalloc (sizeof (struct variable_root));;
 > --- 1687,1693 ----
 >   
 >   /* Allocate memory and initialize a new root variable */
 >   static gdb_variable *
 > ! new_root_variable (void)
 >   {
 >     gdb_variable *var = new_variable ();
 >     var->root = (struct variable_root *) xmalloc (sizeof (struct variable_root));;
 > Index: gdbtk.c
 > ===================================================================
 > RCS file: /cvs/cvsfiles/devo/gdb/gdbtk.c,v
 > retrieving revision 2.143
 > diff -p -r2.143 gdbtk.c
 > *** gdbtk.c	1999/09/19 06:12:27	2.143
 > --- gdbtk.c	1999/09/20 08:19:16
 > ***************
 > *** 64,69 ****
 > --- 64,71 ----
 >   #include <sys/cygwin.h>		/* for cygwin32_attach_handle_to_fd */
 >   #endif
 >   
 > + extern void _initialize_gdbtk (void);
 > + 
 >   #ifndef __CYGWIN32__
 >   /* For unix natives, we use a timer to periodically keep the gui alive.
 >      See comments before x_event. */
 > *************** static int target_should_use_timer PARAM
 > *** 106,113 ****
 >   #endif
 >   
 >   int target_is_native PARAMS ((struct target_ops *t));
 > - 
 > - void gdbtk_add_hooks PARAMS ((void));
 >   
 >   int gdbtk_test PARAMS ((char *));
 >   
 > --- 108,113 ----
 > Index: gdbtk.h
 > ===================================================================
 > RCS file: /cvs/cvsfiles/devo/gdb/gdbtk.h,v
 > retrieving revision 2.12
 > diff -p -r2.12 gdbtk.h
 > *** gdbtk.h	1999/08/28 01:30:09	2.12
 > --- gdbtk.h	1999/09/20 08:19:16
 > *************** extern void
 > *** 169,174 ****
 > --- 169,180 ----
 >         (SYMBOL_DEMANGLED_NAME (symbol) != NULL \
 >          ? SYMBOL_DEMANGLED_NAME (symbol)       \
 >          : SYMBOL_NAME (symbol))
 > + 
 > + 
 > + /* gdbtk_add_hooks - add all the hooks to gdb.  This will get called
 > +    by the startup code to fill in the hooks needed by core gdb. */
 > + extern void gdbtk_add_hooks (void);
 > + 
 >   
 >   /* Local variables: */
 >   /* change-log-default-name: "ChangeLog-gdbtk" */