From: James Ingham <jingham@cygnus.com>
To: Jonathan Larmour <jlarmour@redhat.co.uk>
Cc: Andrew Cagney <ac131313@cygnus.com>,
insight@sourceware.cygnus.com, gdb-patches@sourceware.cygnus.com
Subject: Re: Insight remote output doesn't output to console window immediately
Date: Thu, 13 Apr 2000 18:54:00 -0000 [thread overview]
Message-ID: <14582.31502.754152.913822@leda.cygnus.com> (raw)
In-Reply-To: <38F67617.D1A2A6B3@redhat.co.uk>
Jonathan,
Okay, check this in.
As for the Changelog-gdbtk's. They should be changed to just
ChangeLog - the gdbtk is historic; the C-code files used to live at
the top level, but since Insight couldn't be included in the FSF gdb
releases, we had to have separate ChangeLogs...
The top level ChangeLog-gdbtk does have one or two entries, but I
don't expect that it will really be that useful. But it does no harm.
I do think it is a good idea to have separate ChangeLog's in the
library & generic dirs, since the changes in the generic directory are
all to the gdb<->tcl interface, whereas the library code is pretty
much all the GUI code. So keeping them separate it a bit useful.
Jim
> Andrew Cagney wrote:
> >
> > There is no need for another hook. Even the existing hooks
> > (gdbtk_fputs() and gdbtk_flush()) can, in theory, deleted. To see how
> > it should work, check the MI (mi/mi-main.c) - it maintains a separate
> > stream.
>
> I thought I'd have a look at seeing if I could do this. But it's well
> beyond me (for my spare time anyway), sorry.
>
> > As for a quick hack?
> >
> > My first guess is to, when the GUI is enabled (ie not CLI mode),
> > re-route gdb_stdtarg to gdb_stdout. That might be suitable for the
> > branch. However, the trunk, needs to start taking advantage of ``struct
> > ui_out''.
>
> That's easy enough - see attached. I recommend it go in the trunk as well
> for now unless someone is going to start implementing ui_out for gdbtk RSN.
> Should I check this in to the trunk and the branch then?
>
> BTW, have you noticed that there's a ChangeLog-gdbtk in both gdbtk/ and
> gdbtk/generic, as well as a ChangeLog in gdbtk/library? Is it deliberate?
>
> Jifl
>
> 2000-04-14 Jonathan Larmour <jlarmour@redhat.co.uk>
>
> * gdbtk.c (gdbtk_init): For now, reset gdb_stdtarg to gdb_stdout
> when using gdbtk.
>
> --
> Red Hat, 35 Cambridge Place, Cambridge, UK. CB2 1NS Tel: +44 (1223) 728762
> "Plan to be spontaneous tomorrow." || These opinions are all my own faultIndex: gdbtk/generic/gdbtk.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk.c,v
> retrieving revision 1.1.1.1
> diff -u -5 -p -r1.1.1.1 gdbtk.c
> --- gdbtk/generic/gdbtk.c 2000/02/07 00:19:42 1.1.1.1
> +++ gdbtk/generic/gdbtk.c 2000/04/14 01:29:28
> @@ -528,10 +528,14 @@ gdbtk_find_main";
>
> /* fputs_unfiltered_hook = NULL; *//* Force errors to stdout/stderr */
>
> fputs_unfiltered_hook = gdbtk_fputs;
>
> + /* set gdb_stdtarg for now until gdbtk is changed to use struct ui_out. */
> +
> + gdb_stdtarg = gdb_stdout;
> +
> if (Tcl_GlobalEval (gdbtk_interp, (char *) script) != TCL_OK)
> {
> char *msg;
>
> /* Force errorInfo to be set up propertly. */
next prev parent reply other threads:[~2000-04-13 18:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-04-13 14:46 Jonathan Larmour
2000-04-13 16:53 ` Andrew Cagney
2000-04-13 16:56 ` James Ingham
2000-04-13 18:36 ` Jonathan Larmour
2000-04-13 18:54 ` James Ingham [this message]
2000-04-13 19:49 ` Jonathan Larmour
2000-04-14 8:53 ` James Ingham
2000-04-17 13:07 ` Jonathan Larmour
2000-04-17 13:15 ` James Ingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14582.31502.754152.913822@leda.cygnus.com \
--to=jingham@cygnus.com \
--cc=ac131313@cygnus.com \
--cc=gdb-patches@sourceware.cygnus.com \
--cc=insight@sourceware.cygnus.com \
--cc=jlarmour@redhat.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).