From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Roxborough To: Keith Seitz Cc: insight@sources.redhat.com Subject: Re: Tcl/Tk 8.3 upgrade... Date: Thu, 14 Jun 2001 15:30:00 -0000 Message-id: <20010614152905.67cf7aa6.irox@evilpeople.com> References: <20010614013022.6b55b551.irox@evilpeople.com> X-SW-Source: 2001-q2/msg00378.html On Thu, 14 Jun 2001 08:27:52 -0700 (PDT) Keith Seitz wrote: > On Thu, 14 Jun 2001, Ian Roxborough wrote: > > > Another fix is to switch and rename the hacked tcl_findLibrary with > > the real tcl_findLibrary, so we don't rely on the hack being in > > the Tcl version. > > > > Another fix is to "detect" (if + gdb-tk.o = true...?) > > if we are in the build directory then set the required > > *_LIBRARY variables as needed. > > I'll vote for losing the hacked tcl_findLibrary, and using some heuristic > for determining if we are running in the build dir. Anything to prevent us > from modifying Tcl/Tk/tix/itcl/etc. I'm finding yet more and more local changes to Tcl to make it play nicely with Insight running from the build directory (the ones for launching Tcl in tclInitScript.h). Is anybody going to mind if I install a script at build time to run gdb out of the build directory. Maybe call it run-insight.sh or something. Everything works other than typing ./gdb in the build directory, I'm not sure if this is worth all the code changes vs. a 7 line shell script. It looks like it would be a good idea to revisit how Insight is being launched, making SN location independant made a lot of things easier (I was noticing that if I rename my install dir Insight doesn't work any more). But this is probably outside of the scope the Tcl/Tk upgrade. > > I used insight1.0 as the replacement name for the gdbtcl directory. > > main.tcl does a "package require gdbtk 1.0" and gdbtk.c defines the > package "gdbtk". I would change these all to "insight". I might even > consider bumping the version to differentiate this Tcl8.3-compatible > version from the older one. (Especially since we are going to be ripping > gdb and insight apart...) I'm hoping for very few changes to Insight. Although, by changing the gdbtk to insight effectively changes the version. Ian. -- What would Jenna Bush do?