From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25518 invoked by alias); 12 Feb 2002 23:43:37 -0000 Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sources.redhat.com Received: (qmail 25377 invoked from network); 12 Feb 2002 23:43:34 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 12 Feb 2002 23:43:34 -0000 Received: from localhost.localdomain (cse.cygnus.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with SMTP id PAA24999; Tue, 12 Feb 2002 15:43:26 -0800 (PST) Date: Tue, 12 Feb 2002 15:43:00 -0000 From: Ian Roxborough To: Keith Seitz Cc: insight@sources.redhat.com Subject: Re: [RFA] Move "search in editor" entry box. Message-Id: <20020212153312.55b87e16.irox@redhat.com> In-Reply-To: References: <20020212151036.70a8328f.irox@redhat.com> Organization: Red Hat Inc. X-Mailer: Sylpheed version 0.6.5 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2002-q1/txt/msg00111.txt.bz2 On Tue, 12 Feb 2002 15:23:26 -0800 (PST) Keith Seitz wrote: > > On Tue, 12 Feb 2002, Ian Roxborough wrote: > > > This patch moves the find/search entry box to the toolbar > > above it (where the line number and address used to be). > > It also adds a "Find:" label to it as well. > > I thought we were going to move it to a dialog which would allow you to > search for text, regexp, match case, goto a line number, etc? Yeah, that would be it's intended and prefered destination. But until somebody has the time to work on it I thought we had agreed to just to move it (I could be wrong). If you take a look at the changes to SrcWin::_search, which is now called SrcWin::search, it takes a "string" parameter instead of doing a get on a hardcoded widget path when getting the string to search for. This will make writting a simple search dialog a lot easier, then things can be expanded to include regexps, match case, etc. as we get the time to add these features. Also, breaking it into smaller steps will help avoid large patches. Ian.