From: "Martin M. Hunt" <hunt@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: Insight Mailing List <insight@sources.redhat.com>
Subject: Re: [RFA] Remove src-font
Date: Tue, 05 Mar 2002 13:14:00 -0000 [thread overview]
Message-ID: <200203052114.g25LE1K02842@localhost.localdomain> (raw)
In-Reply-To: <Pine.GSO.4.33.0203051129390.15544-100000@makita.cygnus.com>
How about changing the section in question to this:
# There are a bunch of console prefs that have no UI
# for the user to modify them. In the event that the user
# really wants to change them, they will have to be modified
# in prefs.tcl or by editing .gdbtkinit. When these prefs
# gain a prefs UI, the user may change them dynamically
# and the console window will need notification that they
# have changed. Add them to the following list and
# Console::_update_option.
foreach option {gdb/console/wrap} {
pref add_hook $option [code $this _update_option]
}
On Tuesday 05 March 2002 11:33 am, Keith Seitz wrote:
> On Sat, 2 Mar 2002, Martin M. Hunt wrote:
> > src-font is a prehistoric name for the font used by the source window.
> > It predates libgui and tcl8.0. Libgui creates a bunch of font objects
> > for us and tracks changes to preferences, so src-font long ago became
> > redundant. This patch replaces it with its equivalent, "global/fixed".
>
> Only one question...
>
> > Index: console.itb
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/gdbtk/library/console.itb,v
> > retrieving revision 1.19
> > diff -u -p -r1.19 console.itb
> > --- console.itb 2002/01/18 17:24:29 1.19
> > +++ console.itb 2002/03/03 06:03:16
> > @@ -20,18 +20,6 @@ body Console::constructor {args} {
> > _build_win
> > eval itk_initialize $args
> > add_hook gdb_no_inferior_hook [list $this idle dummy]
> > -
> > - # Right now the preferences window directly uses preference
> > - # variables. This means that if we track the preference changes
> > - # here, things will appear weird to the user -- the console window
> > - # will change before the user chooses Accpet in the prefs window.
> > - # Until the preference window is fixed we can't enable this
> > - # dynamic tracking. FIXME.
> > - # foreach option {gdb/console/wrap gdb/console/prompt_fg \
> > - # gdb/console/error_fg gdb/console/font} {
> > - # pref add_hook $option [code $this _update_option]
> > - # }
> > -
>
> I'd like to update this comment and keep it in (along with the commented
> out Console::_update_option). I believe that you fixed the prefs window
> glitch, so now it is just a matter of re-doing the preferences so that we
> can either add preferences dynamically or we need to update the
> preferences to contain the options specified in this. I know I would
> certainly like to change a few of these (particularly the wrap one).
>
> Otherwise, please check this all in. Thanks.
> Keith
--
Martin Hunt
GDB Engineer
Red Hat, Inc.
next prev parent reply other threads:[~2002-03-05 21:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-02 22:11 Martin M. Hunt
2002-03-05 11:33 ` Keith Seitz
2002-03-05 13:14 ` Martin M. Hunt [this message]
2002-03-05 13:26 ` Keith Seitz
2002-03-05 14:23 ` Martin M. Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200203052114.g25LE1K02842@localhost.localdomain \
--to=hunt@redhat.com \
--cc=insight@sources.redhat.com \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).