From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18970 invoked by alias); 5 Mar 2002 21:14:35 -0000 Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sources.redhat.com Received: (qmail 18914 invoked from network); 5 Mar 2002 21:14:34 -0000 Received: from unknown (HELO localhost.localdomain) (12.230.181.242) by sources.redhat.com with SMTP; 5 Mar 2002 21:14:34 -0000 Received: from there (DRAGON [127.0.0.1]) by localhost.localdomain (8.11.6/8.11.6) with SMTP id g25LE1K02842; Tue, 5 Mar 2002 13:14:01 -0800 Message-Id: <200203052114.g25LE1K02842@localhost.localdomain> Content-Type: text/plain; charset="iso-8859-1" From: "Martin M. Hunt" Organization: Red Hat Inc To: Keith Seitz Subject: Re: [RFA] Remove src-font Date: Tue, 05 Mar 2002 13:14:00 -0000 X-Mailer: KMail [version 1.3.2] Cc: Insight Mailing List References: In-Reply-To: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SW-Source: 2002-q1/txt/msg00176.txt.bz2 How about changing the section in question to this: # There are a bunch of console prefs that have no UI # for the user to modify them. In the event that the user # really wants to change them, they will have to be modified # in prefs.tcl or by editing .gdbtkinit. When these prefs # gain a prefs UI, the user may change them dynamically # and the console window will need notification that they # have changed. Add them to the following list and # Console::_update_option. foreach option {gdb/console/wrap} { pref add_hook $option [code $this _update_option] } On Tuesday 05 March 2002 11:33 am, Keith Seitz wrote: > On Sat, 2 Mar 2002, Martin M. Hunt wrote: > > src-font is a prehistoric name for the font used by the source window. > > It predates libgui and tcl8.0. Libgui creates a bunch of font objects > > for us and tracks changes to preferences, so src-font long ago became > > redundant. This patch replaces it with its equivalent, "global/fixed". > > Only one question... > > > Index: console.itb > > =================================================================== > > RCS file: /cvs/src/src/gdb/gdbtk/library/console.itb,v > > retrieving revision 1.19 > > diff -u -p -r1.19 console.itb > > --- console.itb 2002/01/18 17:24:29 1.19 > > +++ console.itb 2002/03/03 06:03:16 > > @@ -20,18 +20,6 @@ body Console::constructor {args} { > > _build_win > > eval itk_initialize $args > > add_hook gdb_no_inferior_hook [list $this idle dummy] > > - > > - # Right now the preferences window directly uses preference > > - # variables. This means that if we track the preference changes > > - # here, things will appear weird to the user -- the console window > > - # will change before the user chooses Accpet in the prefs window. > > - # Until the preference window is fixed we can't enable this > > - # dynamic tracking. FIXME. > > - # foreach option {gdb/console/wrap gdb/console/prompt_fg \ > > - # gdb/console/error_fg gdb/console/font} { > > - # pref add_hook $option [code $this _update_option] > > - # } > > - > > I'd like to update this comment and keep it in (along with the commented > out Console::_update_option). I believe that you fixed the prefs window > glitch, so now it is just a matter of re-doing the preferences so that we > can either add preferences dynamically or we need to update the > preferences to contain the options specified in this. I know I would > certainly like to change a few of these (particularly the wrap one). > > Otherwise, please check this all in. Thanks. > Keith -- Martin Hunt GDB Engineer Red Hat, Inc.