From: "Martin M. Hunt" <hunt@redhat.com>
To: Insight Mailing List <insight@sources.redhat.com>
Subject: [RFA] readline cleanup
Date: Wed, 06 Mar 2002 22:32:00 -0000 [thread overview]
Message-ID: <200203070631.g276Vtx31403@localhost.localdomain> (raw)
In interface.tcl, the gdbtk readline stuff was trying to call non-existent functions.
I replaced them with something reasonable.
gdb_run_readline_command() is not used. It looks like it MIGHT be useful,
but I don't know what for. Anyone know?
--
Martin Hunt
GDB Engineer
Red Hat, Inc.
2002-03-06 Martin M. Hunt <hunt@redhat.com>
* library/interface.tcl (gdbtk_tcl_readline): Remove
call to "command::insert" and instead insert the command
into the console window.
(gdbtk_tcl_readline_end): Catch the unsets and do not call
non-existent function command::end_multi_line_input.
Index: library/interface.tcl
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/interface.tcl,v
retrieving revision 1.41
diff -u -p -r1.41 interface.tcl
--- interface.tcl 2002/02/18 17:19:44 1.41
+++ interface.tcl 2002/03/07 06:28:37
@@ -512,7 +512,7 @@ proc gdbtk_tcl_trace_find_hook {arg from
# ------------------------------------------------------------------
proc gdb_run_readline_command {command args} {
global gdbtk_state
-# debug "$command $args"
+ debug "$command $args"
set gdbtk_state(readlineArgs) $args
set gdbtk_state(readlineShowUser) 1
gdb_cmd $command
@@ -524,7 +524,7 @@ proc gdb_run_readline_command {command a
# ------------------------------------------------------------------
proc gdb_run_readline_command_no_output {command args} {
global gdbtk_state
-# debug "$command $args"
+ debug "$command $args"
set gdbtk_state(readlineArgs) $args
set gdbtk_state(readlineShowUser) 0
gdb_cmd $command
@@ -535,7 +535,7 @@ proc gdb_run_readline_command_no_output
# ------------------------------------------------------------------
proc gdbtk_tcl_readline_begin {message} {
global gdbtk_state
-# debug "readline begin"
+# debug
set gdbtk_state(readline) 0
if {$gdbtk_state(console) != "" && $gdbtk_state(readlineShowUser)} {
$gdbtk_state(console) insert $message
@@ -547,12 +547,12 @@ proc gdbtk_tcl_readline_begin {message}
# ------------------------------------------------------------------
proc gdbtk_tcl_readline {prompt} {
global gdbtk_state
-# debug "$prompt"
+# debug "prompt=$prompt"
if {[info exists gdbtk_state(readlineArgs)]} {
# Not interactive, so pop the list, and print element.
set cmd [lvarpop gdbtk_state(readlineArgs)]
- if {$gdbtk_state(readlineShowUser)} {
- command::insert_command $cmd
+ if {$gdbtk_state(console) != "" && $gdbtk_state(readlineShowUser)} {
+ $gdbtk_state(console) insert $cmd
}
} else {
# Interactive.
@@ -573,10 +573,9 @@ proc gdbtk_tcl_readline {prompt} {
# ------------------------------------------------------------------
proc gdbtk_tcl_readline_end {} {
global gdbtk_state
-# debug "readline_end"
+# debug
catch {unset gdbtk_state(readlineArgs)}
- unset gdbtk_state(readlineActive)
- command::end_multi_line_input
+ catch {unset gdbtk_state(readlineActive)}
}
# ------------------------------------------------------------------
next reply other threads:[~2002-03-07 6:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-06 22:32 Martin M. Hunt [this message]
2002-03-07 10:42 ` Keith Seitz
2002-03-07 11:40 ` Tom Tromey
2002-03-07 12:25 ` Martin M. Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200203070631.g276Vtx31403@localhost.localdomain \
--to=hunt@redhat.com \
--cc=insight@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).