From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22662 invoked by alias); 15 Jul 2002 06:00:43 -0000 Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sources.redhat.com Received: (qmail 22655 invoked from network); 15 Jul 2002 06:00:40 -0000 Received: from unknown (HELO mta7.pltn13.pbi.net) (64.164.98.8) by sources.redhat.com with SMTP; 15 Jul 2002 06:00:40 -0000 Received: from modrick ([66.120.11.181]) by mta7.pltn13.pbi.net (iPlanet Messaging Server 5.1 (built May 7 2001)) with SMTP id <0GZA009E00HVNE@mta7.pltn13.pbi.net> for insight@sources.redhat.com; Sun, 14 Jul 2002 22:56:19 -0700 (PDT) Date: Sun, 14 Jul 2002 23:00:00 -0000 From: Mo DeJong Subject: Patch to fix Tk `make test` rule To: insight@sources.redhat.com Message-id: <20020714225612.54315bc2.supermo@bayarea.net> Organization: House of Mirth MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-SW-Source: 2002-q3/txt/msg00015.txt.bz2 It seems the `make test` rule does not work for the Tk version on sources. The reason things are broken is that we have a local change that sets TCL_BIN_DIR in the tcl/unix/tclConfig.sh file. After fixing the problem in my local sources by removing the TCL_BIN_DIR from tclConfig.sh, I got the odd feeling that I had already looked at this issue some time in the past. A quick search turned up this thread. http://sources.redhat.com/ml/insight/2001-q3/msg00062.html The issue was never resolved and was left until after the 8.3 upgrade was finished. So here is the patch to really fix this problem once and for all. 2002-07-14 Mo DeJong * unix/configure: Regen. * unix/configure.in: Don't subst TCL_BIN_DIR into tclConfig.sh. * unix/tclConfig.sh.in: Remove TCL_BIN_DIR variable since it should not exist in the tclConfig.sh file. This variable should be set by the SC_PATH_TCLCONFIG macro when the extension's configure script is run. Index: unix/configure.in =================================================================== RCS file: /cvs/src/src/tcl/unix/configure.in,v retrieving revision 1.5 diff -u -r1.5 configure.in --- unix/configure.in 9 Sep 2001 23:56:09 -0000 1.5 +++ unix/configure.in 15 Jul 2002 05:46:02 -0000 @@ -591,7 +591,6 @@ AC_SUBST(TCL_SHARED_LIB_SUFFIX) AC_SUBST(TCL_SHLIB_CFLAGS) AC_SUBST(TCL_SRC_DIR) -AC_SUBST(TCL_BIN_DIR) AC_SUBST(TCL_UNSHARED_LIB_SUFFIX) AC_SUBST(TCL_VERSION) AC_SUBST(VENDORPREFIX) Index: unix/tclConfig.sh.in =================================================================== RCS file: /cvs/src/src/tcl/unix/tclConfig.sh.in,v retrieving revision 1.4 diff -u -r1.4 tclConfig.sh.in --- unix/tclConfig.sh.in 9 Sep 2001 23:56:09 -0000 1.4 +++ unix/tclConfig.sh.in 15 Jul 2002 05:46:03 -0000 @@ -45,9 +45,6 @@ # The name of the Tcl library (may be either a .a file or a shared library): TCL_LIB_FILE='@TCL_LIB_FILE@' -# The directory the Tcl binaries are being built to. -TCL_BIN_DIR='@TCL_BIN_DIR@' - # The fullpath of the Tcl library (used for dependency checking) TCL_LIB_FULL_PATH='@TCL_LIB_FULL_PATH@'