public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Christopher Faylor <cgf@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: Mo DeJong <supermo@bayarea.net>, Insight <insight@sources.redhat.com>
Subject: Re: Patch to avoid using mkfifo under cygwin
Date: Fri, 13 Sep 2002 09:39:00 -0000	[thread overview]
Message-ID: <20020913163905.GA5423@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0209130746340.1407-100000@valrhona.uglyboxes.com>

On Fri, Sep 13, 2002 at 07:47:24AM -0700, Keith Seitz wrote:
>On Thu, 12 Sep 2002, Mo DeJong wrote:
>
>> Here is a patch that avoids calling mkfifo under Cygwin since
>> it is not functional.
>
>Ok, so given cgf's latest comments, do we want to hold off on this or 
>revert it when the cygwin work is ready? Maybe we can write an autoconf 
>test for it?

Given that this is something that will just magically work when the cygwin
DLL is updated, I don't think autoconf is the right way to go.

What's wrong with the current code which returns an error when mkfifo fails?
That seems pretty clear to me.

cgf

>>          case S_IFIFO: {
>>  	    if (mkfifo(dst, srcStatBuf.st_mode) < 0) {	/* INTL: Native. */
>>  		return TCL_ERROR;
>>  	    }

  reply	other threads:[~2002-09-13 16:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-12 15:51 Patch to avoid using mkfifo under Cygwin Mo DeJong
2002-09-12 16:06 ` Patch to avoid using mkfifo under cygwin Christopher Faylor
2002-09-13  7:44 ` Patch to avoid using mkfifo under Cygwin Keith Seitz
2002-09-13  9:39   ` Christopher Faylor [this message]
2002-09-13  9:57     ` Patch to avoid using mkfifo under cygwin Keith Seitz
2002-09-13 11:01       ` Mo DeJong
2002-09-13 11:05         ` Keith Seitz
2002-09-13 14:32           ` Christopher Faylor
2002-09-13 12:22   ` Patch to avoid using mkfifo under Cygwin Andrew Cagney
2002-09-17 10:27 Patch to avoid using mkfifo under cygwin Nicholas Wourms

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020913163905.GA5423@redhat.com \
    --to=cgf@redhat.com \
    --cc=insight@sources.redhat.com \
    --cc=keiths@redhat.com \
    --cc=supermo@bayarea.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).