From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9263 invoked by alias); 10 Oct 2002 23:56:53 -0000 Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sources.redhat.com Received: (qmail 9255 invoked from network); 10 Oct 2002 23:56:52 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 10 Oct 2002 23:56:52 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g9ANarX10443 for ; Thu, 10 Oct 2002 19:36:53 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9ANupf02678 for ; Thu, 10 Oct 2002 19:56:51 -0400 Received: from localhost.localdomain (romulus-int.sfbay.redhat.com [172.16.27.46]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9ANuoa01536 for ; Thu, 10 Oct 2002 19:56:51 -0400 From: "Martin M. Hunt" Organization: Red Hat Inc To: insight@sources.redhat.com Subject: [patch] fix memory window sizing Date: Thu, 10 Oct 2002 16:56:00 -0000 User-Agent: KMail/1.4.1 MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="------------Boundary-00=_RGISZ1OGS0NQ92XRNG3Z" Message-Id: <200210101655.39311.hunt@redhat.com> X-SW-Source: 2002-q4/txt/msg00031.txt.bz2 --------------Boundary-00=_RGISZ1OGS0NQ92XRNG3Z Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8bit Content-length: 303 Memory window was not resizing correctly because gdb_update_mem() was not returning column sizes. -- Martin Hunt GDB Engineer Red Hat, Inc. 2002-10-10 Martin M. Hunt * generic/gdbtk-cmds.c (gdb_update_mem): No results were being returned. Append results to result_ptr_obj_ptr. --------------Boundary-00=_RGISZ1OGS0NQ92XRNG3Z Content-Type: text/x-diff; charset="us-ascii"; name="p" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="p" Content-length: 1118 Index: generic/gdbtk-cmds.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v retrieving revision 1.57 diff -u -p -r1.57 gdbtk-cmds.c --- generic/gdbtk-cmds.c 16 May 2002 01:08:51 -0000 1.57 +++ generic/gdbtk-cmds.c 10 Oct 2002 23:55:06 -0000 @@ -2703,12 +2703,9 @@ gdb_update_mem (ClientData clientData, T } /* return max_*_len so that column widths can be set */ - result = Tcl_NewListObj (0, NULL); - Tcl_ListObjAppendElement (interp, result, Tcl_NewIntObj (max_label_len + 1)); - Tcl_ListObjAppendElement (interp, result, Tcl_NewIntObj (max_val_len + 1)); - Tcl_ListObjAppendElement (interp, result, Tcl_NewIntObj (max_ascii_len + 1)); - result_ptr->flags |= GDBTK_IN_TCL_RESULT; - + Tcl_ListObjAppendElement (interp, result_ptr->obj_ptr, Tcl_NewIntObj (max_label_len + 1)); + Tcl_ListObjAppendElement (interp, result_ptr->obj_ptr, Tcl_NewIntObj (max_val_len + 1)); + Tcl_ListObjAppendElement (interp, result_ptr->obj_ptr, Tcl_NewIntObj (max_ascii_len + 1)); do_cleanups (old_chain); xfree (mbuf); return TCL_OK; --------------Boundary-00=_RGISZ1OGS0NQ92XRNG3Z--