public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Mo DeJong <mdejong@uncounted.org>
To: insight@sources.redhat.com
Subject: Re: Patch: fix tk so that it compiles under mingw
Date: Tue, 14 Jan 2003 01:26:00 -0000	[thread overview]
Message-ID: <20030113172818.00e63e48.mdejong@uncounted.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0211221240430.1555-100000@valrhona.uglyboxes.com>

On Fri, 22 Nov 2002 12:43:11 -0800 (PST)
Keith Seitz <keiths@redhat.com> wrote:

> This patch does not build:
> 
> Creating library file: libcygtk83.a
> tkWinDIalog.o(.text+0x25a9): In function `ChooseDirectoryHookProc':
> /home/keiths/ref/cygwin/tk/win/../../../src/tk/win/tkWinDialog.c:1526: 
> undefined reference to `__T'
> collect2: ld returned 1 exit status

I just tried this myself and it looks like _T is defined in the tchar.h file for
Mingw. Since this is not used in Cygwin, it seems like to right thing to
do is use the TEXT() macro instead. The headers state that __TEXT should
not be used, so this seems better.

2003-01-13  Mo DeJong  <mdejong@uncounted.org>

	* win/tkWinDialog.c (ChooseDirectoryHookProc):
	Use TEXT macro instead of __TEXT, this should
	work with VC++, Mingw, and Cygwin.

Index: win/tkWinDialog.c
===================================================================
RCS file: /cvs/src/src/tk/win/tkWinDialog.c,v
retrieving revision 1.4
diff -u -r1.4 tkWinDialog.c
--- win/tkWinDialog.c	24 Sep 2002 18:39:30 -0000	1.4
+++ win/tkWinDialog.c	14 Jan 2003 01:10:19 -0000
@@ -1523,7 +1523,7 @@
 		     * Directory must exist.  Complain, then rehighlight text.
 		     */
 
-		    wsprintf(tmp, __TEXT("Cannot change directory to \"%.200s\"."), 
+		    wsprintf(tmp, TEXT("Cannot change directory to \"%.200s\"."), 
 			    cdPtr->path);
 		    MessageBox(hwnd, tmp, NULL, MB_OK);
 		    SendDlgItemMessage(hwnd, edt10, EM_SETSEL, 0, -1);

      reply	other threads:[~2003-01-14  1:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-10 10:49 Mo DeJong
2002-11-22 12:43 ` Keith Seitz
2003-01-14  1:26   ` Mo DeJong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030113172818.00e63e48.mdejong@uncounted.org \
    --to=mdejong@uncounted.org \
    --cc=insight@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).