From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12916 invoked by alias); 17 Feb 2003 18:48:17 -0000 Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sources.redhat.com Received: (qmail 12909 invoked from network); 17 Feb 2003 18:48:17 -0000 Received: from unknown (HELO redhat.com) (66.30.22.225) by 172.16.49.205 with SMTP; 17 Feb 2003 18:48:17 -0000 Received: by redhat.com (Postfix, from userid 201) id 3FF5E1BCA4; Mon, 17 Feb 2003 13:48:19 -0500 (EST) Date: Mon, 17 Feb 2003 18:54:00 -0000 From: Christopher Faylor To: insight@sourceware.org Subject: Re: Insight build problem on cygwin (tentative patch enclosed) Message-ID: <20030217184819.GC7514@redhat.com> Reply-To: insight@sourceware.org Mail-Followup-To: insight@sourceware.org References: <83040F98B407E6428FEC18AC720F5D732DB7CA@exchange.tropicnetworks.com> <1045176482.1490.50.camel@lindt.uglyboxes.com> <1045499585.1668.11.camel@lindt.uglyboxes.com> <20030217170407.GC5837@redhat.com> <3E512C0A.1020700@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3E512C0A.1020700@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-q1/txt/msg00140.txt.bz2 [reply-to set] On Mon, Feb 17, 2003 at 01:38:02PM -0500, Andrew Cagney wrote: >>- static const struct interp_procs tk_procs = >>- { >>- tk_init, >>- gdbtk_resume, >>- gdbtk_suspend, >>- gdbtk_exec, >>- gdbtk_prompt_p, >>- gdbtk_command_loop, >>- }; >>- >>- interp_add (interp_new ("gdbtk", NULL, NULL, &tk_procs)); >>- > >FYI, > >Removing from _initialize*() is wrong. Interpreters should only be >registered in _initialize*() function. > >I think the underlying problem is general confusion over the separation >of powers between interp_add() and interp_init(). > >BTW, even with that NULL, it worked for me. Is there something cygwin >centric going on? Don't see how it could be. interp_set does this: uiout = interp->interpreter_out; So, at some point uiout becomes NULL. I wiped out my old non-working version so I can't give the specific instance right now but it seems obvious that this could happen. If you set interpreter_out to NULL and call interp_set at some point then uiout will be NULL. cgf