public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Patrick Samson <p_samson@yahoo.com>
To: insight@sources.redhat.com
Subject: tcl8.4.1 - tclWinInit - TclpInitLibraryPath()
Date: Wed, 14 Jan 2004 09:03:00 -0000	[thread overview]
Message-ID: <20040114090318.75627.qmail@web60305.mail.yahoo.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]

#ifdef __CYGWIN__
	    pathv[pathc - 2] = installLib2;

This adding is useful for X:/cygwin/bin/tclsh.exe to
include "X:/cygwin/usr/share/tcl8.4", which is the
place on cygwin where to find init.tcl.

Unfortunately, it is of no help to:
 X:/cygwin/usr/local/pgsql/bin/pgtclsh.exe
 X:/cygwin/usr/local/pgsql/bin/postgres.exe
because it leads to:
 X:/cygwin/usr/local/pgsql/usr/share/tcl8.4

A way to solve this problem is to define the
TCL_LIBRARY environment variable.

I think that there is a better way to accommodate all
applications on cygwin, without the need to define
TCL_LIBRARY, by moving the use of installLib2 to
AppendDllPath().

As the dll is X:/cygwin/bin/tcl84.dll, AppendDllPath()
would return:
 X:/cygwin/usr/share/tcl8.4
whatever the application executable path is.

I don't have the means to compile/build/test the tcl
package from source, but my proposed patch generated
with:
 $ diff -u tclWinInit.c ../../../../tmp/tclWinInit.c
is attached.


__________________________________
Do you Yahoo!?
Yahoo! Hotjobs: Enter the "Signing Bonus" Sweepstakes
http://hotjobs.sweepstakes.yahoo.com/signingbonus

[-- Attachment #2: diff_tclWinInit.txt --]
[-- Type: text/plain, Size: 1133 bytes --]

--- tclWinInit.c        2003-01-23 06:22:16.001000000 +0100
+++ ../../../../tmp/tclWinInit.c        2004-01-07 13:12:30.640625000 +0100
@@ -228,7 +228,15 @@
      * because in practice, the DLL is always installed.
      */

-    AppendDllPath(pathPtr, TclWinGetTclInstance(), installLib);
+    AppendDllPath(pathPtr, TclWinGetTclInstance(),
+    /* REDHAT LOCAL */
+#ifdef __CYGWIN__
+     installLib2
+#else
+     installLib
+#endif
+    /* END REDHAT LOCAL */
+     );


     /*
@@ -268,17 +276,6 @@
            objPtr = Tcl_NewStringObj(path, Tcl_DStringLength(&ds));
            Tcl_ListObjAppendElement(NULL, pathPtr, objPtr);
            Tcl_DStringFree(&ds);
-           /* REDHAT LOCAL */
-#ifdef __CYGWIN__
-           pathv[pathc - 2] = installLib2;
-           path = Tcl_JoinPath(pathc - 1, pathv, &ds);
-           pathv[pathc - 2] = str;
-           objPtr = Tcl_NewStringObj(path, Tcl_DStringLength(&ds));
-           Tcl_ListObjAppendElement(NULL, pathPtr, objPtr);
-           Tcl_DStringFree(&ds);
-#endif
-           /* END REDHAT LOCAL */
-
        }
        if (pathc > 3) {
            str = pathv[pathc - 3];

                 reply	other threads:[~2004-01-14  9:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040114090318.75627.qmail@web60305.mail.yahoo.com \
    --to=p_samson@yahoo.com \
    --cc=insight@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).