From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32092 invoked by alias); 13 Dec 2004 05:02:34 -0000 Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sources.redhat.com Received: (qmail 31725 invoked from network); 13 Dec 2004 05:01:57 -0000 Received: from unknown (HELO ausmtp01.au.ibm.com) (202.81.18.186) by sourceware.org with SMTP; 13 Dec 2004 05:01:57 -0000 Received: from sd0208e0.au.ibm.com (d23rh904.au.ibm.com [202.81.18.202]) by ausmtp01.au.ibm.com (8.12.10/8.12.10) with ESMTP id iBD53LSi228710 for ; Mon, 13 Dec 2004 16:03:24 +1100 Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.250.237]) by sd0208e0.au.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id iBD53eWo205968 for ; Mon, 13 Dec 2004 16:03:40 +1100 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.12.11/8.12.11) with ESMTP id iBD51kWE009213 for ; Mon, 13 Dec 2004 16:01:46 +1100 Received: from ozlabs.au.ibm.com (haven.au.ibm.com [9.190.164.82]) by d23av04.au.ibm.com (8.12.11/8.12.11) with ESMTP id iBD51k8E009193 for ; Mon, 13 Dec 2004 16:01:46 +1100 Received: from namadgi.ozlabs.ibm.com (localhost [127.0.0.1]) by ozlabs.au.ibm.com (Postfix) with SMTP id 42A8B17DDC for ; Mon, 13 Dec 2004 16:01:45 +1100 (EST) Received: by namadgi.ozlabs.ibm.com (sSMTP sendmail emulation); Mon, 13 Dec 2004 16:03:09 +1100 From: "Ben Elliston" Date: Mon, 13 Dec 2004 05:02:00 -0000 To: insight@sources.redhat.com Subject: some warning patches Message-ID: <20041213050309.GA10532@namadgi> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nFreZHaLTZJo0R7j" Content-Disposition: inline User-Agent: Mutt/1.5.6+20040907i X-SW-Source: 2004-q4/txt/msg00123.txt.bz2 --nFreZHaLTZJo0R7j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2727 This patch should be sufficiently obvious. Perhaps gdbtk_two_elem_cmd should take a const char * as its second argument, but I've just followed the tradition set throughout gdbtk-hooks.c. ;-) Ben 2004-12-13 Ben Elliston Remove some warnings: * generic/gdbtk-hooks.c (gdbtk_pre_add_symbol): Cast `name'. * generic/gdbtk-cmds.c (gdbtk_dis_asm_read_memory): Remove. Index: generic/gdbtk-hooks.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/bje/src-cvs/src/gdb/gdbtk/generic/gdbtk-hooks.c,v retrieving revision 1.38 diff -u -p -r1.38 gdbtk-hooks.c --- generic/gdbtk-hooks.c 26 Jun 2004 20:30:51 -0000 1.38 +++ generic/gdbtk-hooks.c 13 Dec 2004 05:00:16 -0000 @@ -597,7 +597,7 @@ gdbtk_load_hash (const char *section, un static void gdbtk_pre_add_symbol (const char *name) { - gdbtk_two_elem_cmd ("gdbtk_tcl_pre_add_symbol", name); + gdbtk_two_elem_cmd ("gdbtk_tcl_pre_add_symbol", (char *) name); } =20 /* This hook is called whenever we finish loading a symbol file. */ Index: generic/gdbtk-cmds.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/bje/src-cvs/src/gdb/gdbtk/generic/gdbtk-cmds.c,v retrieving revision 1.84 diff -u -p -r1.84 gdbtk-cmds.c --- generic/gdbtk-cmds.c 19 Nov 2004 00:19:56 -0000 1.84 +++ generic/gdbtk-cmds.c 13 Dec 2004 05:00:16 -0000 @@ -180,8 +180,6 @@ static int gdb_stop (ClientData, Tcl_Int static int gdb_target_has_execution_command (ClientData, Tcl_Interp *, int, Tcl_Obj * CONST[]); -static int gdbtk_dis_asm_read_memory (bfd_vma, bfd_byte *, unsigned int, - disassemble_info *); static void gdbtk_load_source (ClientData clientData, struct symtab *symtab, int start_line, int end_line); @@ -2075,27 +2073,6 @@ gdb_disassemble_driver (CORE_ADDR low, C } =20 return TCL_OK; -} - -/* This is the memory_read_func for gdb_disassemble_driver when we are - disassembling from the exec file. */ - -static int -gdbtk_dis_asm_read_memory (bfd_vma memaddr, bfd_byte *myaddr, - unsigned int len, disassemble_info *info) -{ - extern struct target_ops exec_ops; - int res; - - errno =3D 0; - res =3D xfer_memory (memaddr, myaddr, len, 0, 0, &exec_ops); - - if (res =3D=3D len) - return 0; - else if (errno =3D=3D 0) - return EIO; - else - return errno; } =20 /* This will be passed to qsort to sort the results of the disassembly */ --nFreZHaLTZJo0R7j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline Content-length: 189 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) iD8DBQFBvSKNMGpskFPkywkRAtilAJ4he70Tm2tM9Gv8QdepLlSgA0dNEgCeNUU1 3NOlw/PLCkw0nebBdG7SPz4= =qJEm -----END PGP SIGNATURE----- --nFreZHaLTZJo0R7j--