From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27637 invoked by alias); 6 Jul 2005 09:36:00 -0000 Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org Received: (qmail 27609 invoked by uid 22791); 6 Jul 2005 09:35:51 -0000 Received: from gecko.sbs.de (HELO gecko.sbs.de) (194.138.37.40) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 06 Jul 2005 09:35:51 +0000 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.12.6/8.12.6) with ESMTP id j669ZnjL018812 for ; Wed, 6 Jul 2005 11:35:49 +0200 Received: from nsprim.swb.siemens.de (nsprim.swb.siemens.de [141.73.80.3]) by mail2.sbs.de (8.12.6/8.12.6) with ESMTP id j669ZlFI003086 for ; Wed, 6 Jul 2005 11:35:48 +0200 Received: from haiti.swb.siemens.de (haiti.swb.siemens.de [141.73.80.6]) by nsprim.swb.siemens.de (8.9.1/8.9.1) with ESMTP id LAA26811 for ; Wed, 6 Jul 2005 11:35:45 +0200 (MET DST) Received: from sylt (sylt [141.19.4.2]) by haiti.swb.siemens.de (8.11.7+Sun/8.11.7) with SMTP id j669Zkd22389; Wed, 6 Jul 2005 11:35:46 +0200 (MEST) Message-Id: <200507060935.j669Zkd22389@haiti.swb.siemens.de> Date: Wed, 06 Jul 2005 09:36:00 -0000 From: Ruppert Reply-To: Ruppert Subject: small bug in memory window To: insight@sourceware.org Cc: dieter_ruppert@siemens.com MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Content-MD5: BtBr4X4Uz0Ba+/hdeuJWTQ== X-SW-Source: 2005-q3/txt/msg00000.txt.bz2 Hi, we noticed a small bug in Insight's memory window: when the display format is changed, (from "Word" to "Byte", for example), the address displayed resets back to the default (which is usually the start of the .data section). I looked at the code in memwin.itb, and the reason seems obvious: the member variable MemWin::addr_exp is never updated (after being initialized to .data). MemWin::reconfig, which is called after a format change, uses this value, and therefore resets the address to the default. A simple one-line change fixes this; I include a small patch below. BTW: this was Insight from gdb-6.1, but memwin.itb apparently hasn't changed since then. Best Regards Dieter Ruppert *** memwin.itb Wed Jul 6 11:04:41 2005 --- memwin.itb.new Wed Jul 6 11:06:34 2005 *************** *** 512,517 **** --- 512,519 ---- incr index -1 set current_addr [string range $current_addr 0 $index] } + + set MemWin::addr_exp $addr_exp # set table background $itk_component(table) config -bg $::Colors(textbg) -state normal