From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>,
andrew.stubbs@st.com, gdb-patches@sourceware.org,
insight@sourceware.org
Subject: Re: [PATCH] Don't call Insight hooks when not appropriate
Date: Thu, 09 Mar 2006 19:14:00 -0000 [thread overview]
Message-ID: <20060309191426.GA31250@nevyn.them.org> (raw)
In-Reply-To: <20060309191304.GA31165@nevyn.them.org>
On Thu, Mar 09, 2006 at 02:13:04PM -0500, Daniel Jacobowitz wrote:
> On Thu, Mar 09, 2006 at 08:10:56PM +0100, Mark Kettenis wrote:
> > > Date: Thu, 09 Mar 2006 15:37:22 +0000
> > > From: Andrew STUBBS <andrew.stubbs@st.com>
> > >
> > > 2006-03-09 Andrew Stubbs <andrew.stubbs@st.com>
> > >
> > > * cli/cli-script.c (execute_user_command): Set instream to -1, not 0.
> > > (read_command_lines): Check instream before calling the prompt hook.
> >
> > I think this usage of -1 is a bad idea.
>
> Me too. We're already using a global variable; why not just add
> another and restore it in the same cleanup?
Or maybe make the existing user_call_depth global.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-03-09 19:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-09 15:42 Andrew STUBBS
2006-03-09 19:11 ` Mark Kettenis
2006-03-09 19:13 ` Daniel Jacobowitz
2006-03-09 19:14 ` Daniel Jacobowitz [this message]
2006-03-09 20:20 ` Michael Snyder
2006-03-10 11:15 ` Andrew STUBBS
2006-03-10 11:18 ` Andrew STUBBS
2006-03-25 0:04 ` Daniel Jacobowitz
2006-03-27 11:32 ` Andrew STUBBS
2006-03-28 21:59 ` Daniel Jacobowitz
2006-03-29 15:43 ` Andrew STUBBS
2006-03-29 15:49 ` Daniel Jacobowitz
2006-03-29 15:58 ` Andrew STUBBS
2006-03-29 16:29 ` Daniel Jacobowitz
2006-03-29 16:38 ` Andrew STUBBS
2006-03-29 16:45 ` Dave Korn
2006-03-29 18:01 ` Eli Zaretskii
2006-03-29 22:53 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060309191426.GA31250@nevyn.them.org \
--to=drow@false.org \
--cc=andrew.stubbs@st.com \
--cc=gdb-patches@sourceware.org \
--cc=insight@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).