Re: [patch] Only use CW_SYNC_WINENV for Cygwin 1.15.20+

[Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>]

On Mon, May 14, 2007 at 02:49:17PM +0100, Maciej W. Rozycki wrote:
>On Thu, 10 May 2007, Christopher Faylor wrote:
>
>> There is no such thing as Cygwin 1.15.20.  I don't know exactly when this was
>> applied but I would just avoid referring to the exact version of Cygwin in the
>> ChangeLog.
>
> Hmm, your own words:
>
>http://www.cygwin.com/ml/cygwin/2006-07/msg00037.html

You're quoting a message from me which does not mention 1.15.20.  It is
1.*5*.20.

There is no reason to argue about this when a simple removal of the
version is all that I'm asking for.  Changing the "for Cygwin
1.15.20(sic)+" to "when it is supported by the compilation environment"
would be sufficient.

>Or do you mean the missing "-1" suffix?  If so, then sorry -- this can 
>certainly be rectified.  I just copied the change including the comment 
>from elsewhere as is.
>
>> >2007-05-10  Maciej W. Rozycki  <macro@mips.com>
>> >
>> >	* win/tclWinPipe.c (TclpCreateProcess): Only use CW_SYNC_WINENV
>> >	for Cygwin 1.15.20+.
>> >
>> > OK to apply?
>> 
>> No, sorry.  If you are going to be testing versions like this then please
>> use CYGWIN_VERSION_USER_API_VERSION_COMBINED.
>
> Well, no such macro as of 1.5.14, but it was introduced before 
>CW_SYNC_WINENV (at CYGWIN_VERSION_API_MINOR == 147), so it would be OK.  

Ok then I withdraw my suggestion.  Your code is fine as is.

cgf