Re: [patch] Only use CW_SYNC_WINENV for Cygwin 1.15.20+

[Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>]

On Mon, May 14, 2007 at 05:29:00PM +0100, Maciej W. Rozycki wrote:
>On Mon, 14 May 2007, Christopher Faylor wrote:
>
>> You're quoting a message from me which does not mention 1.15.20.  It is
>> 1.*5*.20.
>> 
>> There is no reason to argue about this when a simple removal of the 
>> version is all that I'm asking for.  Changing the "for Cygwin 
>> 1.15.20(sic)+" to "when it is supported by the compilation environment" 
>> would be sufficient.
>
> Well, that's a typo that I've kept missing -- sorry for the confusion.  
>Here's an updated version.
>
>2007-05-14  Maciej W. Rozycki  <macro@mips.com>
>
>	* win/tclWinPipe.c (TclpCreateProcess): Only use CW_SYNC_WINENV
>	if supported by the compilation environment.
>
> OK to apply?

It's ok with me.  Keith, I assume you're ok with it, right?

cgf

>tcl_cw_sync_winenv.diff
>Index: binutils-quilt/src/tcl/win/tclWinPipe.c
>===================================================================
>--- binutils-quilt.orig/src/tcl/win/tclWinPipe.c	2007-05-14 16:16:44.000000000 +0100
>+++ binutils-quilt/src/tcl/win/tclWinPipe.c	2007-05-14 16:18:41.000000000 +0100
>@@ -1228,7 +1228,9 @@
> 
>     BuildCommandLine(execPath, argc, argv, &cmdLine);
> 
>-#ifdef __CYGWIN__
>+#if defined(__CYGWIN__) && \
>+    (CYGWIN_VERSION_API_MAJOR > 0 || CYGWIN_VERSION_API_MINOR >= 154)
>+    /* Only available in Cygwin 1.5.20+. */
>     cygwin_internal (CW_SYNC_WINENV);
> #endif
> 
>