Re: MinGW patches for Insight

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1730 bytes --]

On Friday 08 February 2008, Dave Murphy wrote:
> I'm still not sure how best to format the changelog entries. Should I be
> sending a patchset for each directory where changes are made?

you do it based upon the ChangeLog files that already exist.  look at the file 
you change, and then walk up directories until you hit the first ChangeLog 
file.

>   2008-02-07  Dave Murphy  <davem@devkitpro.org>
>
>         *configure.ac
>         set tcl configdir to win under mingw32

if you look at the existing ChangeLog entries, you'll see these are formatted 
wrong.  it's something like:
	* file (relevant scope in file where applicable): Description of change.

>         *gdb/configure
>         regenerate

while you are supposed to say you regenerated things, you dont actually 
include the changes to configure in patches that get posted to mailing lists 
and such.  generated files are not interesting and tend to contain a lot of 
noise.

> --- gdb/configure.ac    13 Jan 2008 12:23:05 -0000      1.64
> +++ gdb/configure.ac    8 Feb 2008 15:42:43 -0000
> @@ -1445,7 +1445,7 @@
>  AC_SUBST(WIN32LDAPP)
>  
>  case "${host}" in
> -*-*-cygwin*)
> +*-*-cygwin* | *mingw32* )
>      configdir="win"
>      ;;
>  *)

what about 64bit mingw ?

> --- gdb/gdbtk/generic/gdbtk-interp.c    23 Dec 2005 18:23:16 -0000      1.8
> +++ gdb/gdbtk/generic/gdbtk-interp.c    6 Feb 2008 03:50:50 -0000
> @@ -34,6 +34,12 @@
>  #include "tk.h"
>  #include "gdbtk.h"
>  
> +#ifdef __MINGW32__
> +       #define WIN32_LEAN_AND_MEAN
> +       #include <windows.h>
> +#endif

never put whitespace before the #:
#ifdef __MINGW32__
# define WIN32_LEAN_AND_MEAN
# include <windows.h>
#endif
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]