From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31600 invoked by alias); 8 Feb 2008 18:05:31 -0000 Received: (qmail 31590 invoked by uid 22791); 8 Feb 2008 18:05:31 -0000 X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 08 Feb 2008 18:05:06 +0000 Received: from localhost (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 7565D660CA; Fri, 8 Feb 2008 18:05:04 +0000 (UTC) From: Mike Frysinger To: insight@sourceware.org Subject: Re: MinGW patches for Insight Date: Fri, 08 Feb 2008 18:05:00 -0000 User-Agent: KMail/1.9.7 Cc: Dave Murphy References: <47AAC222.2080906@devkitpro.org> <47AC8FC4.8070204@devkitpro.org> In-Reply-To: <47AC8FC4.8070204@devkitpro.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart5157928.RGKWTRs6uh"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200802081304.01150.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00015.txt.bz2 --nextPart5157928.RGKWTRs6uh Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Content-length: 1880 On Friday 08 February 2008, Dave Murphy wrote: > I'm still not sure how best to format the changelog entries. Should I be > sending a patchset for each directory where changes are made? you do it based upon the ChangeLog files that already exist. look at the f= ile=20 you change, and then walk up directories until you hit the first ChangeLog= =20 file. > 2008-02-07 =A0Dave Murphy =A0 > > =A0=A0=A0=A0=A0=A0=A0=A0*configure.ac > =A0=A0=A0=A0=A0=A0=A0=A0set tcl configdir to win under mingw32 if you look at the existing ChangeLog entries, you'll see these are formatt= ed=20 wrong. it's something like: * file (relevant scope in file where applicable): Description of change. > =A0=A0=A0=A0=A0=A0=A0=A0*gdb/configure > =A0=A0=A0=A0=A0=A0=A0=A0regenerate while you are supposed to say you regenerated things, you dont actually=20 include the changes to configure in patches that get posted to mailing list= s=20 and such. generated files are not interesting and tend to contain a lot of= =20 noise. > --- gdb/configure.ac=A0=A0=A0=A013 Jan 2008 12:23:05 -0000=A0=A0=A0=A0=A0= =A01.64 > +++ gdb/configure.ac=A0=A0=A0=A08 Feb 2008 15:42:43 -0000 > @@ -1445,7 +1445,7 @@ > =A0AC_SUBST(WIN32LDAPP) > =A0 > =A0case "${host}" in > -*-*-cygwin*) > +*-*-cygwin* | *mingw32* ) > =A0 =A0 =A0configdir=3D"win" > =A0 =A0 =A0;; > =A0*) what about 64bit mingw ? > --- gdb/gdbtk/generic/gdbtk-interp.c=A0=A0=A0=A023 Dec 2005 18:23:16 -000= 0=A0=A0=A0=A0=A0=A01.8 > +++ gdb/gdbtk/generic/gdbtk-interp.c=A0=A0=A0=A06 Feb 2008 03:50:50 -0000 > @@ -34,6 +34,12 @@ > =A0#include "tk.h" > =A0#include "gdbtk.h" > =A0 > +#ifdef __MINGW32__ > +=A0=A0=A0=A0=A0=A0=A0#define WIN32_LEAN_AND_MEAN > +=A0=A0=A0=A0=A0=A0=A0#include > +#endif never put whitespace before the #: #ifdef __MINGW32__ # define WIN32_LEAN_AND_MEAN # include #endif -mike --nextPart5157928.RGKWTRs6uh Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 827 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) iQIVAwUAR6yZkUFjO5/oN/WBAQIeQw//SwHyt62II6xT9Y6l0rXwIlyf7n3v3pFS ERQR4X5WEs/+k1/LwF1jVeaR5Eh3CWp3sdL5OClbhAbrgrAwtCM3jVdzc+H5zMGW cWkr2YxBtARZesIOZjqsU3i9/QcXAPZ1GVZUrS/fhtapMRbq0UmHm/X3zRmfHjdT BCr2J5sMaNJeX7pvA1GgdQxUlclNTkp+fI9JKwONbRumLXbRvh5AC4XayuE54hCy Y4xWevpbLhHHqr/W3DcdfSIkT0kp16otIuP+zHVP8Mn+Ac2qw4B7u7ZC30hjjPM0 UDks6O6pB+Cd6BcPwcyOSrW4walXlik0+VgzCTW63zq3qWa62SfpbMzlwAnj9DAH 2AC2P53YsumQXFSzqKhBTf++rCsKAMo21gsQ6k2VeM7qPIaC1lIyskAdWXiKDv2/ xCpNJ64LKc+ZDJj4SjitoNOieWHCBeSL0gqegppkaj5XYEtjOGw+opaU37H3DdYO IRZd9s4pkjnngXgTFUHWvf5TFc5BpClnHmFwoX1IdLBCCSfhEfKj5c/zOj3fiVmQ lz7CPHaV7fCc3qHSkUKrcYj4UybJbu6fKpetwAt4dnBifvxZ54VUpL6HfyF8R8X1 ylSdncts+RwfcF3U+BMKctfHul1f8chtFZesv/hY6Zga2UZxALH6Pd1zb9kCRtZP bf8Xd8EUXus= =7aG6 -----END PGP SIGNATURE----- --nextPart5157928.RGKWTRs6uh--