From: Kevin Buettner <kevinb@redhat.com>
To: insight@sourceware.org
Subject: Re: RFA: Fix a 64-bit pointer to integer-of-a-different-size cast error
Date: Mon, 02 Mar 2009 22:48:00 -0000 [thread overview]
Message-ID: <20090302154750.34d457d4@redhat.com> (raw)
In-Reply-To: <20090226152436.18951613@redhat.com>
On Thu, 26 Feb 2009 15:24:36 -0700
Kevin Buettner <kevinb@redhat.com> wrote:
> - arguments = (int) clientData;
> + arguments = (int) (long) clientData;
After some off-list discussion, Keith and I agreed on the following
patch instead:
* generic/gdbtk-stack.c (gdb_get_vars_command): Revise cast of
`clientData' to avoid build error on 64-bit hosts.
Index: generic/gdbtk-stack.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-stack.c,v
retrieving revision 1.31
diff -u -p -r1.31 gdbtk-stack.c
--- generic/gdbtk-stack.c 27 Oct 2008 18:40:12 -0000 1.31
+++ generic/gdbtk-stack.c 2 Mar 2009 22:39:12 -0000
@@ -285,7 +285,7 @@ gdb_get_vars_command (ClientData clientD
return TCL_ERROR;
}
- arguments = (int) clientData;
+ arguments = (long) clientData;
/* Initialize the result pointer to an empty list. */
This patch has been committed.
Kevin
prev parent reply other threads:[~2009-03-02 22:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 22:24 Kevin Buettner
2009-03-02 22:48 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090302154750.34d457d4@redhat.com \
--to=kevinb@redhat.com \
--cc=insight@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).