From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8160 invoked by alias); 2 Mar 2009 22:48:11 -0000 Received: (qmail 8146 invoked by uid 22791); 2 Mar 2009 22:48:08 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Mar 2009 22:48:00 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n22MlqaE012131 for ; Mon, 2 Mar 2009 17:47:52 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n22MlqZv029532 for ; Mon, 2 Mar 2009 17:47:52 -0500 Received: from localhost.localdomain (vpn-12-126.rdu.redhat.com [10.11.12.126]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n22Mlp4Y017682 for ; Mon, 2 Mar 2009 17:47:52 -0500 Date: Mon, 02 Mar 2009 22:48:00 -0000 From: Kevin Buettner To: insight@sourceware.org Subject: Re: RFA: Fix a 64-bit pointer to integer-of-a-different-size cast error Message-ID: <20090302154750.34d457d4@redhat.com> In-Reply-To: <20090226152436.18951613@redhat.com> References: <20090226152436.18951613@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2009-q1/txt/msg00020.txt.bz2 On Thu, 26 Feb 2009 15:24:36 -0700 Kevin Buettner wrote: > - arguments = (int) clientData; > + arguments = (int) (long) clientData; After some off-list discussion, Keith and I agreed on the following patch instead: * generic/gdbtk-stack.c (gdb_get_vars_command): Revise cast of `clientData' to avoid build error on 64-bit hosts. Index: generic/gdbtk-stack.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-stack.c,v retrieving revision 1.31 diff -u -p -r1.31 gdbtk-stack.c --- generic/gdbtk-stack.c 27 Oct 2008 18:40:12 -0000 1.31 +++ generic/gdbtk-stack.c 2 Mar 2009 22:39:12 -0000 @@ -285,7 +285,7 @@ gdb_get_vars_command (ClientData clientD return TCL_ERROR; } - arguments = (int) clientData; + arguments = (long) clientData; /* Initialize the result pointer to an empty list. */ This patch has been committed. Kevin