From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2019 invoked by alias); 7 Jul 2009 15:26:33 -0000 Received: (qmail 2003 invoked by uid 22791); 7 Jul 2009 15:26:32 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 07 Jul 2009 15:26:23 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.14.3/8.13.8) with ESMTP id n67FQLlB164754; Tue, 7 Jul 2009 15:26:21 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n67FQKOs2134256; Tue, 7 Jul 2009 17:26:20 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n67FQKTd022556; Tue, 7 Jul 2009 17:26:20 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n67FQIPu022540; Tue, 7 Jul 2009 17:26:18 +0200 Message-Id: <200907071526.n67FQIPu022540@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 07 Jul 2009 17:26:18 +0200 Subject: Re: [RFC] Insight build problem: was [06/15] Per-breakpoint architecture support To: muller@ics.u-strasbg.fr (Pierre Muller) Date: Tue, 07 Jul 2009 15:26:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, insight@sourceware.org In-Reply-To: <001801c9ff01$5b1ae830$1150b890$@u-strasbg.fr> from "Pierre Muller" at Jul 07, 2009 02:49:24 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2009-q3/txt/msg00014.txt.bz2 Pierre Muller wrote: > This seems harmless as the function is not in any header, but > this function is used in gdbtk sources. > I don't really know if gdbtk failures qualify for patches > as such, but it seems to me that it would be difficult to > change the gdbtk-bp.c code to avoid using this function. Ah, I must have thought the missing static was just an oversight. (And the overlooked the change when putting together the ChangeLog entry, sorry.) > Is this failure a sufficient reason to accept this patch > or should we go another route (maybe add set_raw_breakpoint > to breakpoint.h header ?). It's not particularly nice, but I'm OK with leaving it the way it was for now ... Longer term we should find out why the exported interfaces like set_breakpoint are not suitable for gdbtk, and extend them if necessary. > @@ -4396,8 +4397,9 @@ static void free_bp_location (struct bp_ > > /* Helper to set_raw_breakpoint below. Creates a breakpoint > that has type BPTYPE and has no locations as yet. */ > +/* This function is used in gdbtk sources and thus can not be made static. > */ > > -static struct breakpoint * > +struct breakpoint * > set_raw_breakpoint_without_location (struct gdbarch *gdbarch, > enum bptype bptype) > { This chunk seems unnecessary; set_raw_breakpoint_without_location was static before my patch as well. The rest is OK. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com