From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27927 invoked by alias); 12 Apr 2011 00:24:24 -0000 Received: (qmail 27918 invoked by uid 22791); 12 Apr 2011 00:24:22 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BT,TW_DB,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Apr 2011 00:24:04 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3C0O4sq027512 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 11 Apr 2011 20:24:04 -0400 Received: from mesquite.lan (ovpn-113-25.phx2.redhat.com [10.3.113.25]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p3C0O2rh026234 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Mon, 11 Apr 2011 20:24:04 -0400 Date: Tue, 12 Apr 2011 00:24:00 -0000 From: Kevin Buettner To: insight@sourceware.org Subject: Re: [PATCH] Rotate ChangeLog, fix build issues Message-ID: <20110411172402.2ea07ba2@mesquite.lan> In-Reply-To: <4D9FDFD8.7080109@redhat.com> References: <4D9F9BB2.1070904@redhat.com> <4D9FDFD8.7080109@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2011-q2/txt/msg00003.txt.bz2 > 2011-04-08 Keith Seitz > > * generic/gdbtk-bp.c (tracepoint_exists): Remove recently > removed "not_found_ptr" argument from call to decode_line_1. > * generic/gdbtk-stack.c (gdb_get_vars_command): Likewise. > * generic/gdbtk-cmds.c (gdb_get_line_command): Likewise. > (gdb_get_file_command): Likewise. > (gdb_get_function_command): Likewise. Was this actually committed? I was about to post a similar patch, but then noticed that you had already posted it. (Don't see it committed though.) In addition to the above, I do have one other change which avoids an error along the lines of `buffer' being used before being initalized in gdbtk-register.c's get_register(). It appears that valaddr was added with the intention of replacing buffer[], but the switch from one to the other (where buffer is used) was forgotten about. Here's that change: * gdbtk-register.c (get_register): Delete declaration of `buffer'. Use `valaddr' in its place. Index: gdbtk/generic/gdbtk-register.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-register.c,v retrieving revision 1.40 diff -u -p -r1.40 gdbtk-register.c --- gdbtk/generic/gdbtk-register.c 8 Apr 2011 23:32:42 -0000 1.40 +++ gdbtk/generic/gdbtk-register.c 12 Apr 2011 00:08:28 -0000 @@ -276,7 +276,6 @@ get_register (int regnum, map_arg arg) CORE_ADDR addr; enum lval_type lval; struct type *reg_vtype; - gdb_byte buffer[MAX_REGISTER_SIZE]; int format; struct cleanup *old_chain = NULL; struct ui_file *stb; @@ -330,7 +329,7 @@ get_register (int regnum, map_arg arg) { int idx = ((gdbarch_byte_order (gdbarch) == BFD_ENDIAN_BIG) ? j : register_size (gdbarch, regnum) - 1 - j); - sprintf (ptr, "%02x", (unsigned char) buffer[idx]); + sprintf (ptr, "%02x", (unsigned char) valaddr[idx]); ptr += 2; } fputs_unfiltered (buf, stb);