public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: insight@sourceware.org
Subject: [RFA] Fix build error in gdbtk-cmds.c
Date: Sat, 13 Apr 2013 01:00:00 -0000	[thread overview]
Message-ID: <20130412180033.7a6e9a8f@mesquite.lan> (raw)

Recent changes to GDB have caused this error:

../src/gdb/gdbtk/generic/gdbtk-cmds.c: In function 'pc_function_name':
../src/gdb/gdbtk/generic/gdbtk-cmds.c:2998: error: incompatible types when assigning to type 'struct minimal_symbol *' from type 'struct bound_minimal_symbol'

The patch below fixes this problem.

Okay?

	* generic/gdbtk-cmds.c (pc_function_name): Adjust type of
	`msym' to account for change in return type of
	lookup_minimal_symbol_by_pc().

Index: gdbtk/generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.130
diff -u -p -r1.130 gdbtk-cmds.c
--- gdbtk/generic/gdbtk-cmds.c	16 Nov 2012 21:05:38 -0000	1.130
+++ gdbtk/generic/gdbtk-cmds.c	13 Apr 2013 00:51:02 -0000
@@ -2993,11 +2993,11 @@ pc_function_name (CORE_ADDR pc)
   else
     {
       /* ... if that fails, look it up in the minimal symbols. */
-      struct minimal_symbol *msym = NULL;
+      struct bound_minimal_symbol msym;
 
       msym = lookup_minimal_symbol_by_pc (pc);
-      if (msym != NULL)
-	funcname = GDBTK_SYMBOL_SOURCE_NAME (msym);
+      if (msym.minsym != NULL)
+	funcname = GDBTK_SYMBOL_SOURCE_NAME (msym.minsym);
     }
 
   if (funcname == NULL)

             reply	other threads:[~2013-04-13  1:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-13  1:00 Kevin Buettner [this message]
2013-04-13 15:49 ` Keith Seitz
2013-04-13 17:01   ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130412180033.7a6e9a8f@mesquite.lan \
    --to=kevinb@redhat.com \
    --cc=insight@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).