From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18278 invoked by alias); 13 Apr 2013 01:00:37 -0000 Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org Received: (qmail 18267 invoked by uid 89); 13 Apr 2013 01:00:37 -0000 X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_BT,TW_DB autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 13 Apr 2013 01:00:36 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3D10Z0U029906 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 12 Apr 2013 21:00:35 -0400 Received: from mesquite.lan (ovpn-113-70.phx2.redhat.com [10.3.113.70]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r3D10YcP022962 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Fri, 12 Apr 2013 21:00:34 -0400 Date: Sat, 13 Apr 2013 01:00:00 -0000 From: Kevin Buettner To: insight@sourceware.org Subject: [RFA] Fix build error in gdbtk-cmds.c Message-ID: <20130412180033.7a6e9a8f@mesquite.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2013-q2/txt/msg00000.txt.bz2 Recent changes to GDB have caused this error: ../src/gdb/gdbtk/generic/gdbtk-cmds.c: In function 'pc_function_name': ../src/gdb/gdbtk/generic/gdbtk-cmds.c:2998: error: incompatible types when assigning to type 'struct minimal_symbol *' from type 'struct bound_minimal_symbol' The patch below fixes this problem. Okay? * generic/gdbtk-cmds.c (pc_function_name): Adjust type of `msym' to account for change in return type of lookup_minimal_symbol_by_pc(). Index: gdbtk/generic/gdbtk-cmds.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v retrieving revision 1.130 diff -u -p -r1.130 gdbtk-cmds.c --- gdbtk/generic/gdbtk-cmds.c 16 Nov 2012 21:05:38 -0000 1.130 +++ gdbtk/generic/gdbtk-cmds.c 13 Apr 2013 00:51:02 -0000 @@ -2993,11 +2993,11 @@ pc_function_name (CORE_ADDR pc) else { /* ... if that fails, look it up in the minimal symbols. */ - struct minimal_symbol *msym = NULL; + struct bound_minimal_symbol msym; msym = lookup_minimal_symbol_by_pc (pc); - if (msym != NULL) - funcname = GDBTK_SYMBOL_SOURCE_NAME (msym); + if (msym.minsym != NULL) + funcname = GDBTK_SYMBOL_SOURCE_NAME (msym.minsym); } if (funcname == NULL)