public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
* [RFA] Fix build error in gdbtk-cmds.c
@ 2013-04-13  1:00 Kevin Buettner
  2013-04-13 15:49 ` Keith Seitz
  0 siblings, 1 reply; 3+ messages in thread
From: Kevin Buettner @ 2013-04-13  1:00 UTC (permalink / raw)
  To: insight

Recent changes to GDB have caused this error:

../src/gdb/gdbtk/generic/gdbtk-cmds.c: In function 'pc_function_name':
../src/gdb/gdbtk/generic/gdbtk-cmds.c:2998: error: incompatible types when assigning to type 'struct minimal_symbol *' from type 'struct bound_minimal_symbol'

The patch below fixes this problem.

Okay?

	* generic/gdbtk-cmds.c (pc_function_name): Adjust type of
	`msym' to account for change in return type of
	lookup_minimal_symbol_by_pc().

Index: gdbtk/generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.130
diff -u -p -r1.130 gdbtk-cmds.c
--- gdbtk/generic/gdbtk-cmds.c	16 Nov 2012 21:05:38 -0000	1.130
+++ gdbtk/generic/gdbtk-cmds.c	13 Apr 2013 00:51:02 -0000
@@ -2993,11 +2993,11 @@ pc_function_name (CORE_ADDR pc)
   else
     {
       /* ... if that fails, look it up in the minimal symbols. */
-      struct minimal_symbol *msym = NULL;
+      struct bound_minimal_symbol msym;
 
       msym = lookup_minimal_symbol_by_pc (pc);
-      if (msym != NULL)
-	funcname = GDBTK_SYMBOL_SOURCE_NAME (msym);
+      if (msym.minsym != NULL)
+	funcname = GDBTK_SYMBOL_SOURCE_NAME (msym.minsym);
     }
 
   if (funcname == NULL)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFA] Fix build error in gdbtk-cmds.c
  2013-04-13  1:00 [RFA] Fix build error in gdbtk-cmds.c Kevin Buettner
@ 2013-04-13 15:49 ` Keith Seitz
  2013-04-13 17:01   ` Kevin Buettner
  0 siblings, 1 reply; 3+ messages in thread
From: Keith Seitz @ 2013-04-13 15:49 UTC (permalink / raw)
  To: Kevin Buettner; +Cc: insight

On 04/12/2013 06:00 PM, Kevin Buettner wrote:
> Okay?

Yes. Thank you!

Keith

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFA] Fix build error in gdbtk-cmds.c
  2013-04-13 15:49 ` Keith Seitz
@ 2013-04-13 17:01   ` Kevin Buettner
  0 siblings, 0 replies; 3+ messages in thread
From: Kevin Buettner @ 2013-04-13 17:01 UTC (permalink / raw)
  To: insight

On Sat, 13 Apr 2013 08:49:44 -0700
Keith Seitz <keiths@redhat.com> wrote:

> On 04/12/2013 06:00 PM, Kevin Buettner wrote:
> > Okay?
> 
> Yes. Thank you!

Committed.

Kevin

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-04-13 17:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-13  1:00 [RFA] Fix build error in gdbtk-cmds.c Kevin Buettner
2013-04-13 15:49 ` Keith Seitz
2013-04-13 17:01   ` Kevin Buettner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).