From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31620 invoked by alias); 7 Oct 2019 21:09:33 -0000 Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org Received: (qmail 31607 invoked by uid 89); 7 Oct 2019 21:09:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*MI:google X-HELO: mail-yb1-f202.google.com Received: from mail-yb1-f202.google.com (HELO mail-yb1-f202.google.com) (209.85.219.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 Oct 2019 21:09:32 +0000 Received: by mail-yb1-f202.google.com with SMTP id w18so12623864ybq.1 for ; Mon, 07 Oct 2019 14:09:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=pXxYVnWSqNIp4C9mcDc5TNV3MWu0iBxdlUVQGzvZQ/Q=; b=onVXVbJ4zwxW8pGVm2yBXnRf5v08j0JrBm137syCce89FdXHQBm0jNqJ1fF2YlTVKE vOsiGBBICARGCWXidcGGdpg61b0lU2NkVQHDzNozlnpdFkjZynDsSvwiOv0yhHffgC0J LZeojKk6ehSSG8sVXpKVrytbx8+ppEpK+VK23okla1Q6kVaZwej6X4p+AWdbLmtQ09Ql gesk1r2jK4yBhBWZd3W7lm11CZiBNJBAfQSmeWc1uwa7FlrC1q7wa2hjJKBiXtXu2xb+ 2kwMGxHrlkJUjBW0a7X2BzH+0esSSPS+sfoqNcrLMhvb/4VGS4FxxjCd8/Bx+E38GQHA pF9w== Date: Mon, 07 Oct 2019 21:09:00 -0000 Message-Id: <20191007210928.239798-1-cbiesinger@google.com> Mime-Version: 1.0 Subject: [PATCH] Add declarations to gdbtk.h From: "Christian Biesinger via insight" Reply-To: Christian Biesinger To: insight@sourceware.org Cc: Christian Biesinger Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2019-q4/txt/msg00000.txt.bz2 From: Christian Biesinger Currently, gdb/main.c has to declare these two variables in the .c file. This patch adds the declarations to the header so that gdb can just use them. gdbtk/ChangeLog: 2019-10-07 Christian Biesinger * generic/gdbtk.h (gdbtk_test): Declare. (external_editor_command): Declare. (file): Prefix Tcl_Interp with "struct" so that this compiles when Tcl headers aren't included. * generic/gdbtk-interp.h: Likewise. --- gdbtk/generic/gdbtk-interp.h | 2 +- gdbtk/generic/gdbtk.h | 11 +++++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/gdbtk/generic/gdbtk-interp.h b/gdbtk/generic/gdbtk-interp.h index 3126b91..9abad2e 100644 --- a/gdbtk/generic/gdbtk-interp.h +++ b/gdbtk/generic/gdbtk-interp.h @@ -53,7 +53,7 @@ public: ui_file *_stdtargin; ui_out *uiout; - Tcl_Interp *tcl; + struct Tcl_Interp *tcl; }; extern gdbtk_interp *gdbtk_get_interp (void); diff --git a/gdbtk/generic/gdbtk.h b/gdbtk/generic/gdbtk.h index 7bb1f79..89ab8bf 100644 --- a/gdbtk/generic/gdbtk.h +++ b/gdbtk/generic/gdbtk.h @@ -77,6 +77,12 @@ extern int running_now; extern long gdbtk_pid; +/* + * This variable controls the interaction with an external editor. + */ + +extern char *external_editor_command; + /* These two control how the GUI behaves when tracing or loading They are defined in gdbtk-cmds.c */ @@ -91,7 +97,7 @@ extern int load_in_progress; typedef struct gdbtk_result { - Tcl_Obj *obj_ptr; /* This will eventually be copied over to the + struct Tcl_Obj *obj_ptr; /* This will eventually be copied over to the Tcl result */ int flags; /* Flag vector to control how the result is used. */ @@ -151,7 +157,7 @@ extern int gdbtk_force_detach; * */ -extern int Gdbtk_Init (Tcl_Interp * interp); +extern int Gdbtk_Init (struct Tcl_Interp * interp); extern void gdbtk_stop_timer (void); extern void gdbtk_start_timer (void); extern long gdbtk_getpid(void); @@ -159,6 +165,7 @@ extern void gdbtk_ignorable_warning (const char *, const char *); extern int x_event (int); extern int gdbtk_two_elem_cmd (char *, const char *); extern int target_is_native (struct target_ops *t); +extern int gdbtk_test (char *); extern struct ui_file *gdbtk_fileopen (void); extern bool gdbtk_disable_write; extern ptid_t gdbtk_get_ptid (void); -- 2.23.0.581.g78d2f28ef7-goog