Re: [PATCH] gdbtk: Remove use deprecated_interactive_hook

[Keith Seitz <keiths@redhat.com>]

On 6/18/19 3:32 AM, Andrew Burgess wrote:
> The deprecated_interactive_hook is currently setup to point to an
> empty function.  Removing this will allow a small clean up in GDB.
> The empty function used by deprecated_interactive_hook currently looks
> like this:
> 
>     /* Come here during long calculations to check for GUI events.  Usually invoked
>        via the QUIT macro.  */
> 
>     void
>     gdbtk_interactive (void)
>     {
>       /* Tk_DoOneEvent (TK_DONT_WAIT|TK_IDLE_EVENTS); */
>     }
> 
> As far as I can tell this function has been empty for years.  If in
> the future we do ever want or need to implement something like
> gdbtk_interactive, then we would be better off adding a new observable
> to GDB, but I don't see a reason to add one at this point just so that
> gdbtk can call an empty function.
> 
> ChangeLog:
> 
> 	* gdbtk/generic/gdbtk-hooks.c (gdbtk_add_hooks): Don't setup
> 	deprecated_interactive_hook.
> 	* gdbtk/generic/gdbtk.c (gdbtk_interactive): Delete.
> 	* gdbtk/generic/gdbtk.h (gdbtk_interactive): Delete declaration.

Wowser, how time flies when you're working on a release!

I would approve this, but it appears that Patrick has already adjusted the code
based on the related patch getting into gdb:

commit d8772263cdb55564e93528cf16248d3479d23346 (HEAD -> master, origin/master, origin/HEAD)
Author: Patrick Monnerat <patrick@monnerat.net>
Date:   Thu Jun 20 14:58:09 2019 +0200

    Upgrade submodule, sync code.
    
    deprecated_interactive hook has disappeared: remove its (noop) use.
    
    * gdbtk/generic/gdbtk-hooks.c (gdbtk_add_hooks): remove setting of
      deprecated_interactive_hook.
    * gdbtk/generic/gdbtk.[ch] (gdbtk_interactive): remove.

I appreciate that you took the time to take a look, and, of course, thanks for
the patch.

Keith