From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92609 invoked by alias); 22 Jun 2019 17:28:54 -0000 Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org Received: (qmail 92601 invoked by uid 89); 22 Jun 2019 17:28:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=submodule, approve, sk:depreca, gui X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 22 Jun 2019 17:28:52 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9FA8D3084288; Sat, 22 Jun 2019 17:28:51 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn-116-171.phx2.redhat.com [10.3.116.171]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6A52F601A0; Sat, 22 Jun 2019 17:28:51 +0000 (UTC) Subject: Re: [PATCH] gdbtk: Remove use deprecated_interactive_hook To: Andrew Burgess , insight@sourceware.org References: <20190618103217.18629-1-andrew.burgess@embecosm.com> From: Keith Seitz Message-ID: <2f15fa3a-9ba4-8a00-7646-d6b28894db7a@redhat.com> Date: Sat, 22 Jun 2019 17:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190618103217.18629-1-andrew.burgess@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-q2/txt/msg00002.txt.bz2 On 6/18/19 3:32 AM, Andrew Burgess wrote: > The deprecated_interactive_hook is currently setup to point to an > empty function. Removing this will allow a small clean up in GDB. > The empty function used by deprecated_interactive_hook currently looks > like this: > > /* Come here during long calculations to check for GUI events. Usually invoked > via the QUIT macro. */ > > void > gdbtk_interactive (void) > { > /* Tk_DoOneEvent (TK_DONT_WAIT|TK_IDLE_EVENTS); */ > } > > As far as I can tell this function has been empty for years. If in > the future we do ever want or need to implement something like > gdbtk_interactive, then we would be better off adding a new observable > to GDB, but I don't see a reason to add one at this point just so that > gdbtk can call an empty function. > > ChangeLog: > > * gdbtk/generic/gdbtk-hooks.c (gdbtk_add_hooks): Don't setup > deprecated_interactive_hook. > * gdbtk/generic/gdbtk.c (gdbtk_interactive): Delete. > * gdbtk/generic/gdbtk.h (gdbtk_interactive): Delete declaration. Wowser, how time flies when you're working on a release! I would approve this, but it appears that Patrick has already adjusted the code based on the related patch getting into gdb: commit d8772263cdb55564e93528cf16248d3479d23346 (HEAD -> master, origin/master, origin/HEAD) Author: Patrick Monnerat Date: Thu Jun 20 14:58:09 2019 +0200 Upgrade submodule, sync code. deprecated_interactive hook has disappeared: remove its (noop) use. * gdbtk/generic/gdbtk-hooks.c (gdbtk_add_hooks): remove setting of deprecated_interactive_hook. * gdbtk/generic/gdbtk.[ch] (gdbtk_interactive): remove. I appreciate that you took the time to take a look, and, of course, thanks for the patch. Keith