public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: "Insight (GDB GUI)" <insight@sourceware.cygnus.com>
Subject: For review: Volatile and -Wreturn-type in gdbtk-hooks.c
Date: Sun, 29 Aug 1999 22:41:00 -0000	[thread overview]
Message-ID: <37CA195C.A9B9C852@cygnus.com> (raw)

Hello,

The attached patch:

	o	makes several flags volatile

	o	fixes a missing return result

Andrew

Mon Aug 30 15:34:42 1999  Andrew Cagney  <cagney@b1.cygnus.com>

	* gdbtk-hooks.c (x_event): Missing result to return - return 0.
  	Make in_x_event volatile.
	(in_fputs): Make volatile.
Index: gdbtk-hooks.c
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/gdbtk-hooks.c,v
retrieving revision 2.27
diff -p -r2.27 gdbtk-hooks.c
*** gdbtk-hooks.c	1999/08/07 01:27:45	2.27
--- gdbtk-hooks.c	1999/08/30 05:38:01
***************
*** 60,66 ****
  #include "annotate.h"
  #include <sys/time.h>
  
! int in_fputs = 0;
  
  /* Set by gdb_stop, this flag informs x_event to tell its caller
     that it should forcibly detach from the target. */
--- 60,66 ----
  #include "annotate.h"
  #include <sys/time.h>
  
! volatile int in_fputs = 0;
  
  /* Set by gdb_stop, this flag informs x_event to tell its caller
     that it should forcibly detach from the target. */
*************** int
*** 412,422 ****
  x_event (signo)
       int signo;
  {
!   static int in_x_event = 0;
    static Tcl_Obj *varname = NULL;
    static int count = 0;
    if (in_x_event || in_fputs)
!     return;
  
    in_x_event = 1;
    gdbtk_force_detach = 0;
--- 412,422 ----
  x_event (signo)
       int signo;
  {
!   static volatile int in_x_event = 0;
    static Tcl_Obj *varname = NULL;
    static int count = 0;
    if (in_x_event || in_fputs)
!     return 0;
  
    in_x_event = 1;
    gdbtk_force_detach = 0;

                 reply	other threads:[~1999-08-29 22:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37CA195C.A9B9C852@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=insight@sourceware.cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).