From: Andrew Cagney <ac131313@cygnus.com>
To: "Staggs, Kevin P (AZ75)" <Staggs_Kevin@htc.honeywell.com>
Cc: "'insight@sourceware.cygnus.com'" <insight@sourceware.cygnus.com>
Subject: Re: Problem in gdbtk-cmds.c
Date: Mon, 08 Nov 1999 20:57:00 -0000 [thread overview]
Message-ID: <3827A952.850F4BD0@cygnus.com> (raw)
In-Reply-To: <7D2706D329C7D1118EC200805F15C5E44DAF74@htc-az75.htc.honeywell.com>
Hello,
The attatched should fix the problem. It updates the code to match the
new semantics of target_read_memory_partial.
JimI, Ok?
Andrew
"Staggs, Kevin P (AZ75)" wrote:
>
> Hello,
> I have found a problem in gdbtk-cmds.c in the 19991018 version. Line 3262
> of gdbtk-cmds.c is as follows:
> rnum = target_read_memory_partial (addr, mbuf, nbytes, NULL);
> The target_read_memory_partion function is in target.c at line 943 and looks
> like:
> int
> target_read_memory_partial (CORE_ADDR memaddr, char *buf, int len, int *err)
> {
> return target_xfer_memory_partial (memaddr, buf, len, 0, err);
> }
> Immediately above in target.c is the target_xfer_memory_partial function.
> Most of the successful paths will write a 0 to *err and *err is set to NULL.
> This results in a segmentation violation in insight and a crash.
>
> Thanks
> Kevin Staggs
Tue Nov 9 15:40:51 1999 Andrew Cagney <cagney@b1.cygnus.com>
* gdbtk-cmds.c (gdb_get_mem): Keep calling
target_read_memory_partial until all the data is read.
Index: gdbtk-cmds.c
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/gdbtk-cmds.c,v
retrieving revision 2.62
diff -p -r2.62 gdbtk-cmds.c
*** gdbtk-cmds.c 1999/11/02 00:27:40 2.62
--- gdbtk-cmds.c 1999/11/09 04:52:20
*************** gdb_get_mem (clientData, interp, objc, o
*** 3259,3265 ****
memset (mbuf, 0, nbytes + 32);
mptr = cptr = mbuf;
! rnum = target_read_memory_partial (addr, mbuf, nbytes, NULL);
if (objc == 7)
aschar = *(Tcl_GetStringFromObj (objv[6], NULL));
--- 3259,3274 ----
memset (mbuf, 0, nbytes + 32);
mptr = cptr = mbuf;
! rnum = 0;
! while (rnum < nbytes)
! {
! int error;
! int num = target_read_memory_partial (addr + rnum, mbuf + rnum,
! nbytes - rnum, &error);
! if (num <= 0)
! break;
! rnum += num;
! }
if (objc == 7)
aschar = *(Tcl_GetStringFromObj (objv[6], NULL));
next prev parent reply other threads:[~1999-11-08 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-11-06 12:12 Staggs, Kevin P (AZ75)
1999-11-06 22:50 ` Andrew Cagney
1999-11-08 20:57 ` Andrew Cagney [this message]
1999-11-09 9:30 ` James Ingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3827A952.850F4BD0@cygnus.com \
--to=ac131313@cygnus.com \
--cc=Staggs_Kevin@htc.honeywell.com \
--cc=insight@sourceware.cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).