From: Andrew Cagney <ac131313@cygnus.com>
To: "Insight (GDB GUI)" <insight@sourceware.cygnus.com>
Subject: Minor memory display cleanups
Date: Thu, 18 Nov 1999 02:46:00 -0000 [thread overview]
Message-ID: <3833D8F3.D3BDB236@cygnus.com> (raw)
Hello,
The attatched fixes some minor problems with the memory display window -
corrects the comment and a test.
Andrew
Thu Nov 18 19:03:28 1999 Andrew Cagney <cagney@b1.cygnus.com>
* gdbtk-cmds.c (gdb_get_mem): Document nbr parameter. Fix check
on nbr and nbytes parameters.
Index: gdbtk-cmds.c
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/gdbtk-cmds.c,v
retrieving revision 2.63
diff -p -r2.63 gdbtk-cmds.c
*** gdbtk-cmds.c 1999/11/10 00:03:04 2.63
--- gdbtk-cmds.c 1999/11/18 10:41:24
*************** gdb_loc (clientData, interp, objc, objv)
*** 3173,3189 ****
/* This implements the Tcl command 'gdb_get_mem', which
* dumps a block of memory
* Arguments:
! * gdb_get_mem addr form size num aschar
*
* addr: address of data to dump
* form: a char indicating format
* size: size of each element; 1,2,4, or 8 bytes
! * num: the number of bytes to read
! * acshar: an optional ascii character to use in ASCII dump
*
* Return:
! * a list of elements followed by an optional ASCII dump
! */
static int
gdb_get_mem (clientData, interp, objc, objv)
--- 3173,3190 ----
/* This implements the Tcl command 'gdb_get_mem', which
* dumps a block of memory
* Arguments:
! * gdb_get_mem addr form size nbytes bpr aschar
*
* addr: address of data to dump
* form: a char indicating format
* size: size of each element; 1,2,4, or 8 bytes
! * nbytes: the number of bytes to read
! * bpr: bytes per row
! * aschar: if present, an ASCII dump of the row is included. ASCHAR
! * used for unprintable characters.
*
* Return:
! * a list of elements followed by an optional ASCII dump */
static int
gdb_get_mem (clientData, interp, objc, objv)
*************** gdb_get_mem (clientData, interp, objc, o
*** 3223,3229 ****
result_ptr->flags |= GDBTK_IN_TCL_RESULT;
return TCL_ERROR;
}
! else if (size <= 0)
{
Tcl_SetStringObj (result_ptr->obj_ptr,
"Invalid number of bytes, must be > 0",
--- 3224,3230 ----
result_ptr->flags |= GDBTK_IN_TCL_RESULT;
return TCL_ERROR;
}
! else if (nbytes <= 0)
{
Tcl_SetStringObj (result_ptr->obj_ptr,
"Invalid number of bytes, must be > 0",
*************** gdb_get_mem (clientData, interp, objc, o
*** 3236,3242 ****
result_ptr->flags |= GDBTK_IN_TCL_RESULT;
return TCL_ERROR;
}
! else if (size <= 0)
{
Tcl_SetStringObj (result_ptr->obj_ptr,
"Invalid bytes per row, must be > 0", -1);
--- 3237,3243 ----
result_ptr->flags |= GDBTK_IN_TCL_RESULT;
return TCL_ERROR;
}
! else if (bpr <= 0)
{
Tcl_SetStringObj (result_ptr->obj_ptr,
"Invalid bytes per row, must be > 0", -1);
reply other threads:[~1999-11-18 2:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3833D8F3.D3BDB236@cygnus.com \
--to=ac131313@cygnus.com \
--cc=insight@sourceware.cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).